From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from szxga06-in.huawei.com ([45.249.212.32]:57870 "EHLO huawei.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726032AbeHBFN2 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Thu, 2 Aug 2018 01:13:28 -0400
Message-ID: <5B627963.8050608@huawei.com>
Date: Thu, 2 Aug 2018 11:24:19 +0800
From: zhong jiang <zhongjiang@huawei.com>
MIME-Version: 1.0
To: Matthew Wilcox <willy@infradead.org>
CC: <viro@zeniv.linux.org.uk>, <linux-fsdevel@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] fs/binfmt_elf: remove the same condition check
References: <1533175228-17547-1-git-send-email-zhongjiang@huawei.com> <20180802023412.GA25338@bombadil.infradead.org>
In-Reply-To: <20180802023412.GA25338@bombadil.infradead.org>
Content-Type: text/plain; charset="ISO-8859-1"
Content-Transfer-Encoding: 7bit
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On 2018/8/2 10:34, Matthew Wilcox wrote:
> On Thu, Aug 02, 2018 at 10:00:28AM +0800, zhong jiang wrote:
>> dump_align is used to double check in a expression. It is redundant.
>> so just remove one of them.
> You're wrong.  Functions in C can have side-effects (and this one does).
>
>
Ok,  I miss that.  Thank you for clarification.

Thanks,
zhong jiang