From: piaojun <piaojun@huawei.com>
To: Vivek Goyal <vgoyal@redhat.com>
Cc: <linux-fsdevel@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<linux-nvdimm@lists.01.org>, kbuild test robot <lkp@intel.com>,
<kvm@vger.kernel.org>, <miklos@szeredi.hu>,
<virtio-fs@redhat.com>,
"Sebastien Boeuf" <sebastien.boeuf@intel.com>
Subject: Re: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport
Date: Tue, 27 Aug 2019 17:41:38 +0800 [thread overview]
Message-ID: <5D64FAD2.2050906@huawei.com> (raw)
In-Reply-To: <20190826130607.GB3561@redhat.com>
On 2019/8/26 21:06, Vivek Goyal wrote:
> On Mon, Aug 26, 2019 at 09:43:08AM +0800, piaojun wrote:
>
> [..]
>>> +static bool vp_get_shm_region(struct virtio_device *vdev,
>>> + struct virtio_shm_region *region, u8 id)
>>> +{
>>> + struct virtio_pci_device *vp_dev = to_vp_device(vdev);
>>> + struct pci_dev *pci_dev = vp_dev->pci_dev;
>>> + u8 bar;
>>> + u64 offset, len;
>>> + phys_addr_t phys_addr;
>>> + size_t bar_len;
>>> + char *bar_name;
>>
>> 'char *bar_name' should be cleaned up to avoid compiling warning. And I
>> wonder if you mix tab and blankspace for code indent? Or it's just my
>> email display problem?
>
> Will get rid of now unused bar_name.
>
OK
> Generally git flags if there are tab/space issues. I did not see any. So
> if you see something, point it out and I will fix it.
>
cohuck found the same indent problem and pointed them in another email.
Jun
next prev parent reply other threads:[~2019-08-27 9:41 UTC|newest]
Thread overview: 77+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-21 17:57 [PATCH v3 00/19][RFC] virtio-fs: Enable DAX support Vivek Goyal
2019-08-21 17:57 ` [PATCH 01/19] dax: remove block device dependencies Vivek Goyal
2019-08-26 11:51 ` Christoph Hellwig
2019-08-27 16:38 ` Vivek Goyal
2019-08-28 6:58 ` Christoph Hellwig
2019-08-28 17:58 ` Vivek Goyal
2019-08-28 22:53 ` Dave Chinner
2019-08-29 0:04 ` Dan Williams
2019-08-29 9:32 ` Christoph Hellwig
2019-12-16 18:10 ` Vivek Goyal
2020-01-07 12:51 ` Christoph Hellwig
2020-01-07 14:22 ` Dan Williams
2020-01-07 17:07 ` Darrick J. Wong
2020-01-07 17:29 ` Dan Williams
2020-01-07 18:01 ` Vivek Goyal
2020-01-07 18:07 ` Dan Williams
2020-01-07 18:33 ` Vivek Goyal
2020-01-07 18:49 ` Dan Williams
2020-01-07 19:02 ` Darrick J. Wong
2020-01-07 19:46 ` Dan Williams
2020-01-07 23:38 ` Dan Williams
2020-01-09 11:24 ` Jan Kara
2020-01-09 20:03 ` Dan Williams
2020-01-10 12:36 ` Christoph Hellwig
2020-01-14 20:31 ` Vivek Goyal
2020-01-14 20:39 ` Dan Williams
2020-01-14 21:28 ` Vivek Goyal
2020-01-14 22:23 ` Dan Williams
2020-01-15 19:56 ` Vivek Goyal
2020-01-15 20:17 ` Dan Williams
2020-01-15 21:08 ` Jeff Moyer
2020-01-16 18:09 ` Dan Williams
2020-01-16 18:39 ` Vivek Goyal
2020-01-16 19:09 ` Dan Williams
2020-01-16 19:23 ` Vivek Goyal
2020-02-11 17:33 ` Vivek Goyal
2020-01-15 9:03 ` Jan Kara
2019-08-21 17:57 ` [PATCH 02/19] dax: Pass dax_dev to dax_writeback_mapping_range() Vivek Goyal
2019-08-26 11:53 ` Christoph Hellwig
2019-08-26 20:33 ` Vivek Goyal
2019-08-26 20:58 ` Vivek Goyal
2019-08-26 21:33 ` Dan Williams
2019-08-28 6:58 ` Christoph Hellwig
2020-01-03 14:12 ` Vivek Goyal
2020-01-03 18:12 ` Dan Williams
2020-01-03 18:18 ` Dan Williams
2020-01-03 18:33 ` Vivek Goyal
2020-01-03 19:30 ` Dan Williams
2020-01-03 18:43 ` Vivek Goyal
2019-08-27 13:45 ` Jan Kara
2019-08-21 17:57 ` [PATCH 03/19] virtio: Add get_shm_region method Vivek Goyal
2019-08-21 17:57 ` [PATCH 04/19] virtio: Implement get_shm_region for PCI transport Vivek Goyal
2019-08-26 1:43 ` [Virtio-fs] " piaojun
2019-08-26 13:06 ` Vivek Goyal
2019-08-27 9:41 ` piaojun [this message]
2019-08-27 8:34 ` Cornelia Huck
2019-08-27 8:46 ` Cornelia Huck
2019-08-27 11:53 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 05/19] virtio: Implement get_shm_region for MMIO transport Vivek Goyal
2019-08-27 8:39 ` Cornelia Huck
2019-08-27 11:54 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 06/19] fuse, dax: add fuse_conn->dax_dev field Vivek Goyal
2019-08-21 17:57 ` [PATCH 07/19] virtio_fs, dax: Set up virtio_fs dax_device Vivek Goyal
2019-08-21 17:57 ` [PATCH 08/19] fuse: Keep a list of free dax memory ranges Vivek Goyal
2019-08-21 17:57 ` [PATCH 09/19] fuse: implement FUSE_INIT map_alignment field Vivek Goyal
2019-08-21 17:57 ` [PATCH 10/19] fuse: Introduce setupmapping/removemapping commands Vivek Goyal
2019-08-21 17:57 ` [PATCH 11/19] fuse, dax: Implement dax read/write operations Vivek Goyal
2019-08-21 19:49 ` Liu Bo
2019-08-22 12:59 ` Vivek Goyal
2019-08-21 17:57 ` [PATCH 12/19] fuse, dax: add DAX mmap support Vivek Goyal
2019-08-21 17:57 ` [PATCH 13/19] fuse: Define dax address space operations Vivek Goyal
2019-08-21 17:57 ` [PATCH 14/19] fuse, dax: Take ->i_mmap_sem lock during dax page fault Vivek Goyal
2019-08-21 17:57 ` [PATCH 15/19] fuse: Maintain a list of busy elements Vivek Goyal
2019-08-21 17:57 ` [PATCH 16/19] dax: Create a range version of dax_layout_busy_page() Vivek Goyal
2019-08-21 17:57 ` [PATCH 17/19] fuse: Add logic to free up a memory range Vivek Goyal
2019-08-21 17:57 ` [PATCH 18/19] fuse: Release file in process context Vivek Goyal
2019-08-21 17:57 ` [PATCH 19/19] fuse: Take inode lock for dax inode truncation Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5D64FAD2.2050906@huawei.com \
--to=piaojun@huawei.com \
--cc=kvm@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvdimm@lists.01.org \
--cc=lkp@intel.com \
--cc=miklos@szeredi.hu \
--cc=sebastien.boeuf@intel.com \
--cc=vgoyal@redhat.com \
--cc=virtio-fs@redhat.com \
--subject='Re: [Virtio-fs] [PATCH 04/19] virtio: Implement get_shm_region for PCI transport' \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).