From: walter harms <wharms@bfs.de>
To: linux-man@vger.kernel.org, darrick.wong@oracle.com,
dhowells@redhat.com, jaegeuk@kernel.org,
linux-api@vger.kernel.org, linux-ext4@vger.kernel.org,
linux-f2fs-devel@lists.sourceforge.net,
linux-fscrypt@vger.kernel.org, linux-fsdevel@vger.kernel.org,
tytso@mit.edu, victorhsieh@google.com
Subject: Re: [man-pages RFC PATCH] statx.2: document STATX_ATTR_VERITY
Date: Sat, 09 Nov 2019 20:34:51 +0100 [thread overview]
Message-ID: <5DC714DB.9060007@bfs.de> (raw)
In-Reply-To: <20191108193557.GA12997@gmail.com>
Am 08.11.2019 20:35, schrieb Eric Biggers:
> On Fri, Nov 08, 2019 at 09:23:04AM +0100, walter harms wrote:
>>
>>
>> Am 07.11.2019 23:02, schrieb Eric Biggers:
>>> From: Eric Biggers <ebiggers@google.com>
>>>
>>> Document the verity attribute for statx().
>>>
>>> Signed-off-by: Eric Biggers <ebiggers@google.com>
>>> ---
>>> man2/statx.2 | 4 ++++
>>> 1 file changed, 4 insertions(+)
>>>
>>> RFC since the kernel patches are currently under review.
>>> The kernel patches can be found here:
>>> https://lkml.kernel.org/linux-fscrypt/20191029204141.145309-1-ebiggers@kernel.org/T/#u
>>>
>>> diff --git a/man2/statx.2 b/man2/statx.2
>>> index d2f1b07b8..713bd1260 100644
>>> --- a/man2/statx.2
>>> +++ b/man2/statx.2
>>> @@ -461,6 +461,10 @@ See
>>> .TP
>>> .B STATX_ATTR_ENCRYPTED
>>> A key is required for the file to be encrypted by the filesystem.
>>> +.TP
>>> +.B STATX_ATTR_VERITY
>>> +The file has fs-verity enabled. It cannot be written to, and all reads from it
>>> +will be verified against a Merkle tree.
>>
>> Using "Merkle tree" opens a can of worm and what will happen when the methode will change ?
>> Does it matter at all ? i would suggest "filesystem" here.
>>
>
> Fundamentally, fs-verity guarantees that all data read is verified against a
> cryptographic hash that covers the entire file. I think it will be helpful to
> convey that here, e.g. to avoid confusion with non-cryptographic, individual
> block checksums supported by filesystems like btrfs and zfs.
>
> Now, the only sane way to implement this model is with a Merkle tree, and this
> is part of the fs-verity UAPI (via the file hash), so that's where I'm coming
> from here. Perhaps the phrase "Merkle tree" could be interpreted too strictly,
> though, so it would be better to emphasize the more abstract model. How about
> the following?:
>
> The file has fs-verity enabled. It cannot be written to, and all reads
> from it will be verified against a cryptographic hash that covers the
> entire file, e.g. via a Merkle tree.
>
"feels" better,. but from a programmers perspective it is important at what level
this is actually done. To see my point look at the line before.
"encrypted by the filesystem" mean i have to read the documentation of the fs first
so if encryption is supported at all. Or do i think to complicated ?
jm2c,
re
wh
next prev parent reply other threads:[~2019-11-09 19:35 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-29 20:41 [PATCH 0/4] statx: expose the fs-verity bit Eric Biggers
2019-10-29 20:41 ` [PATCH 1/4] statx: define STATX_ATTR_VERITY Eric Biggers
2019-10-30 18:26 ` Andreas Dilger
2019-11-07 1:44 ` Darrick J. Wong
2019-11-07 2:05 ` Andreas Dilger
2019-11-07 22:02 ` [man-pages RFC PATCH] statx.2: document STATX_ATTR_VERITY Eric Biggers
2019-11-08 0:47 ` Darrick J. Wong
2019-11-08 8:23 ` walter harms
2019-11-08 19:35 ` Eric Biggers
2019-11-09 19:34 ` walter harms [this message]
2019-11-13 20:31 ` Eric Biggers
2019-11-07 22:12 ` [PATCH 1/4] statx: define STATX_ATTR_VERITY Eric Biggers
2019-10-29 20:41 ` [PATCH 2/4] ext4: support STATX_ATTR_VERITY Eric Biggers
2019-10-30 18:27 ` Andreas Dilger
2019-10-29 20:41 ` [PATCH 3/4] f2fs: " Eric Biggers
2019-10-29 20:41 ` [PATCH 4/4] docs: fs-verity: mention statx() support Eric Biggers
2019-11-06 21:57 ` [PATCH 0/4] statx: expose the fs-verity bit Eric Biggers
2019-11-13 20:20 ` Eric Biggers
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5DC714DB.9060007@bfs.de \
--to=wharms@bfs.de \
--cc=darrick.wong@oracle.com \
--cc=dhowells@redhat.com \
--cc=jaegeuk@kernel.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fscrypt@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-man@vger.kernel.org \
--cc=tytso@mit.edu \
--cc=victorhsieh@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).