linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: William Kucharski <william.kucharski@oracle.com>
To: "Matthew Wilcox (Oracle)" <willy@infradead.org>
Cc: linux-fsdevel@vger.kernel.org, linux-mm@kvack.org,
	Mel Gorman <mgorman@techsingularity.net>
Subject: Re: [PATCH 0/3] Wait for I/O without holding a page reference
Date: Tue, 13 Oct 2020 07:32:23 -0600	[thread overview]
Message-ID: <5EEF6D22-639C-492E-BF81-C6239D68ABFD@oracle.com> (raw)
In-Reply-To: <20201013030008.27219-1-willy@infradead.org>



> On Oct 12, 2020, at 9:00 PM, Matthew Wilcox (Oracle) <willy@infradead.org> wrote:
> 
> The upcoming THP patchset keeps THPs Uptodate at all times unless we
> hit an I/O error.  So I have a patch which induces I/O errors in 10%
> of readahead I/Os in order to test the fallback path.  It hits a
> problem with xfstests generic/273 which has 500 threads livelocking
> trying to split the THP.  This patchset fixes that livelock and
> takes 21 lines out of generic_file_buffered_read().
> 
> Matthew Wilcox (Oracle) (3):
>  mm: Pass a sleep state to put_and_wait_on_page_locked
>  mm/filemap: Don't hold a page reference while waiting for unlock
>  mm: Inline __wait_on_page_locked_async into caller
> 
> include/linux/pagemap.h |   3 +-
> mm/filemap.c            | 129 +++++++++++++++-------------------------
> mm/huge_memory.c        |   4 +-
> mm/migrate.c            |   4 +-
> 4 files changed, 52 insertions(+), 88 deletions(-)
> 
> -- 
> 2.28.0

For the series:

Reviewed-by: William Kucharski <william.kucharski@oracle.com>


      parent reply	other threads:[~2020-10-13 13:32 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-13  3:00 [PATCH 0/3] Wait for I/O without holding a page reference Matthew Wilcox (Oracle)
2020-10-13  3:00 ` [PATCH 1/3] mm: Pass a sleep state to put_and_wait_on_page_locked Matthew Wilcox (Oracle)
2020-10-13  3:00 ` [PATCH 2/3] mm: Don't hold a page reference while waiting for unlock Matthew Wilcox (Oracle)
2020-10-13 13:32   ` Matthew Wilcox
2020-10-13  3:00 ` [PATCH 2/3] mm/filemap: " Matthew Wilcox (Oracle)
2020-10-13  3:00 ` [PATCH 3/3] mm: Inline __wait_on_page_locked_async into caller Matthew Wilcox (Oracle)
2020-10-13 13:32 ` William Kucharski [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=5EEF6D22-639C-492E-BF81-C6239D68ABFD@oracle.com \
    --to=william.kucharski@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mgorman@techsingularity.net \
    --cc=willy@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).