From: Jens Axboe <axboe@kernel.dk>
To: dsterba@suse.cz, Ming Lei <ming.lei@redhat.com>,
linux-block@vger.kernel.org, Qu Wenruo <quwenruo.btrfs@gmx.com>,
linux-btrfs@vger.kernel.org, linux-fsdevel@vger.kernel.org,
Omar Sandoval <osandov@fb.com>, Christoph Hellwig <hch@lst.de>
Subject: Re: [PATCH V3] block: don't use for-inside-for in bio_for_each_segment_all
Date: Thu, 11 Apr 2019 09:07:25 -0600 [thread overview]
Message-ID: <5c317eff-32bb-8f9f-defd-fc707b65316f@kernel.dk> (raw)
In-Reply-To: <20190411132652.GP29086@twin.jikos.cz>
On 4/11/19 7:26 AM, David Sterba wrote:
> On Mon, Apr 08, 2019 at 08:19:59AM -0600, Jens Axboe wrote:
>> On 4/8/19 5:02 AM, Ming Lei wrote:
>>> Commit 6dc4f100c175 ("block: allow bio_for_each_segment_all() to
>>> iterate over multi-page bvec") changes bio_for_each_segment_all()
>>> to use for-inside-for.
>>>
>>> This way breaks all bio_for_each_segment_all() call with error out
>>> branch via 'break', since now 'break' can only break from the inner
>>> loop.
>>>
>>> Fixes this issue by implementing bio_for_each_segment_all() via
>>> single 'for' loop, and now the logic is very similar with normal
>>> bvec iterator.
>>
>> Applied, thanks Ming.
>
> What's the merge target please? This affects btrfs testing so I wonder
> if we should start adding workarounds or just wait for the next rc.
> Thanks.
It's queued up in my for-linus, so it's for this series. It'll go
upstream tomorrow.
--
Jens Axboe
prev parent reply other threads:[~2019-04-11 15:07 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-08 11:02 [PATCH V3] block: don't use for-inside-for in bio_for_each_segment_all Ming Lei
2019-04-08 11:20 ` Johannes Thumshirn
2019-04-08 14:19 ` Jens Axboe
2019-04-11 13:26 ` David Sterba
2019-04-11 15:07 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5c317eff-32bb-8f9f-defd-fc707b65316f@kernel.dk \
--to=axboe@kernel.dk \
--cc=dsterba@suse.cz \
--cc=hch@lst.de \
--cc=linux-block@vger.kernel.org \
--cc=linux-btrfs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=osandov@fb.com \
--cc=quwenruo.btrfs@gmx.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).