From: Chao Yu <yuchao0@huawei.com>
To: Nathan Chancellor <natechancellor@gmail.com>,
Daniel Rosenberg <drosen@google.com>
Cc: Jaegeuk Kim <jaegeuk@kernel.org>,
Jonathan Corbet <corbet@lwn.net>,
<linux-f2fs-devel@lists.sourceforge.net>,
<linux-kernel@vger.kernel.org>, <linux-doc@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, <linux-api@vger.kernel.org>,
<kernel-team@android.com>
Subject: Re: [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups
Date: Thu, 1 Aug 2019 09:11:13 +0800 [thread overview]
Message-ID: <5d6c5da8-ad1e-26e2-0a3d-84949cd4e9aa@huawei.com> (raw)
In-Reply-To: <20190731175748.GA48637@archlinux-threadripper>
Hi Nathan,
Thanks for the report! :)
On 2019/8/1 1:57, Nathan Chancellor wrote:
> Hi all,
>
> <snip>
>
>> diff --git a/fs/f2fs/hash.c b/fs/f2fs/hash.c
>> index cc82f142f811f..99e79934f5088 100644
>> --- a/fs/f2fs/hash.c
>> +++ b/fs/f2fs/hash.c
>> @@ -14,6 +14,7 @@
>> #include <linux/f2fs_fs.h>
>> #include <linux/cryptohash.h>
>> #include <linux/pagemap.h>
>> +#include <linux/unicode.h>
>>
>> #include "f2fs.h"
>>
>> @@ -67,7 +68,7 @@ static void str2hashbuf(const unsigned char *msg, size_t len,
>> *buf++ = pad;
>> }
>>
>> -f2fs_hash_t f2fs_dentry_hash(const struct qstr *name_info,
>> +static f2fs_hash_t __f2fs_dentry_hash(const struct qstr *name_info,
>> struct fscrypt_name *fname)
>> {
>> __u32 hash;
>> @@ -103,3 +104,35 @@ f2fs_hash_t f2fs_dentry_hash(const struct qstr *name_info,
>> f2fs_hash = cpu_to_le32(hash & ~F2FS_HASH_COL_BIT);
>> return f2fs_hash;
>> }
>> +
>> +f2fs_hash_t f2fs_dentry_hash(const struct inode *dir,
>> + const struct qstr *name_info, struct fscrypt_name *fname)
>> +{
>> +#ifdef CONFIG_UNICODE
>> + struct f2fs_sb_info *sbi = F2FS_SB(dir->i_sb);
>> + const struct unicode_map *um = sbi->s_encoding;
>> + int r, dlen;
>> + unsigned char *buff;
>> + struct qstr *folded;
>> +
>> + if (name_info->len && IS_CASEFOLDED(dir)) {
>> + buff = f2fs_kzalloc(sbi, sizeof(char) * PATH_MAX, GFP_KERNEL);
>> + if (!buff)
>> + return -ENOMEM;
>> +
>> + dlen = utf8_casefold(um, name_info, buff, PATH_MAX);
>> + if (dlen < 0) {
>> + kvfree(buff);
>> + goto opaque_seq;
>> + }
>> + folded->name = buff;
>> + folded->len = dlen;
>> + r = __f2fs_dentry_hash(folded, fname);
>> +
>> + kvfree(buff);
>> + return r;
>> + }
>> +opaque_seq:
>> +#endif
>> + return __f2fs_dentry_hash(name_info, fname);
>> +}
>
> Clang now warns:
>
> fs/f2fs/hash.c:128:3: warning: variable 'folded' is uninitialized when used here [-Wuninitialized]
> folded->name = buff;
> ^~~~~~
> fs/f2fs/hash.c:116:21: note: initialize the variable 'folded' to silence this warning
> struct qstr *folded;
> ^
> = NULL
> 1 warning generated.
>
> I assume that it wants to be initialized with f2fs_kzalloc as well but
> I am not familiar with this code and what it expects to do.
>
> Please look into this when you get a chance!
That should be a bug, it needs to define a struct qstr type variable rather than
a pointer there.
Jaegeuk, could you fix this in you branch?
Thanks,
> Nathan
> .
>
next prev parent reply other threads:[~2019-08-01 1:11 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-23 23:05 [PATCH v4 0/3] Casefolding in F2FS Daniel Rosenberg
2019-07-23 23:05 ` [PATCH v4 1/3] fs: Reserve flag for casefolding Daniel Rosenberg
2019-07-28 0:36 ` [f2fs-dev] " Chao Yu
2019-07-23 23:05 ` [PATCH v4 2/3] f2fs: include charset encoding information in the superblock Daniel Rosenberg
2019-07-28 0:45 ` [f2fs-dev] " Chao Yu
2019-07-23 23:05 ` [PATCH v4 3/3] f2fs: Support case-insensitive file name lookups Daniel Rosenberg
2019-07-28 0:55 ` [f2fs-dev] " Chao Yu
2019-07-29 6:27 ` Jaegeuk Kim
2019-07-29 7:22 ` Chao Yu
2019-07-29 14:57 ` Chao Yu
2019-07-31 17:57 ` Nathan Chancellor
2019-08-01 1:11 ` Chao Yu [this message]
2019-08-01 4:05 ` Jaegeuk Kim
2019-08-21 13:15 ` [f2fs-dev] " Chao Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5d6c5da8-ad1e-26e2-0a3d-84949cd4e9aa@huawei.com \
--to=yuchao0@huawei.com \
--cc=corbet@lwn.net \
--cc=drosen@google.com \
--cc=jaegeuk@kernel.org \
--cc=kernel-team@android.com \
--cc=linux-api@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-f2fs-devel@lists.sourceforge.net \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=natechancellor@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).