From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F04A7C43381 for ; Thu, 21 Mar 2019 15:16:40 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id C9D5221874 for ; Thu, 21 Mar 2019 15:16:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728396AbfCUPQf (ORCPT ); Thu, 21 Mar 2019 11:16:35 -0400 Received: from mx1.redhat.com ([209.132.183.28]:45240 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728032AbfCUPQe (ORCPT ); Thu, 21 Mar 2019 11:16:34 -0400 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4B86A307D90F; Thu, 21 Mar 2019 15:16:34 +0000 (UTC) Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98]) by smtp.corp.redhat.com (Postfix) with ESMTP id ED03C1001DE4; Thu, 21 Mar 2019 15:16:31 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <3463221.D14WHduXq3@blindfold> References: <3463221.D14WHduXq3@blindfold> <155316902426.29884.2476392753144421312.stgit@warthog.procyon.org.uk> To: Richard Weinberger Cc: dhowells@redhat.com, viro@zeniv.linux.org.uk, linux-block@vger.kernel.org, squashfs-devel@lists.sourceforge.net, Marek Vasut , Brian Norris , Nicolas Pitre , Boris Brezillon , linux-mtd@lists.infradead.org, David Woodhouse , Phillip Lougher , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [RFC PATCH 0/6] Convert mount_single-using filesystems to fs_context MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <6006.1553181386.1@warthog.procyon.org.uk> Date: Thu, 21 Mar 2019 15:16:26 +0000 Message-ID: <6007.1553181386@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.48]); Thu, 21 Mar 2019 15:16:34 +0000 (UTC) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Bah. The problem is that vfs_get_super() doesn't set fc->root before calling reconfigure_super(). David