From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-1.0 required=3.0 tests=DKIMWL_WL_MED,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_PASS, URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 05242C282CC for ; Wed, 6 Feb 2019 17:56:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id BEDEC20811 for ; Wed, 6 Feb 2019 17:56:48 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="zujoRw3h" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730932AbfBFR4q (ORCPT ); Wed, 6 Feb 2019 12:56:46 -0500 Received: from mail-it1-f195.google.com ([209.85.166.195]:53811 "EHLO mail-it1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1730979AbfBFR4q (ORCPT ); Wed, 6 Feb 2019 12:56:46 -0500 Received: by mail-it1-f195.google.com with SMTP id g85so8172003ita.3 for ; Wed, 06 Feb 2019 09:56:45 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=KJdCduGQXkMCaFAWwR05XHxaYoJ8ahmV6XEx6DRT85U=; b=zujoRw3hA5lZ0EuuDAjilCtsAA/SXnb3s1gVfLsCkEK70LjKUC7WDufGRqdiHwJCgw MGRxJ77EnpvFbV52pzLV2UAYqVnIyrldvChqL2A8n79DaQi1QB/sY8cnfYoEtDKSZFs3 rMI//RKd6MpB/SKb8I5OuV9q/Er30aMuj2t0X4oyQ0SsIEo6uai6qFakv3h3yPXuzONI OF1+tjjbPGdqzjf4SIJ0fVfjhFA7wvSy/qr0YLw+Cl5ZvDLlSRbpnEN9tPi69rMj0Bd0 hsSvH8RJa4gJqGU4Pv/t/lyZeIKAlXbRDCmFJVfxH7WKbPkBPrxPiWf3ARSc1gjg2gIy 5Isg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=KJdCduGQXkMCaFAWwR05XHxaYoJ8ahmV6XEx6DRT85U=; b=Iq4M6TdLfD5bYlhsoBq+3rZ3kOLcc7+4g7xNBNjLVktJzG9xvmnSH2Lv4FyQUXeRww t3sXCvzsUnReG9FVXQxKwHD2w/uF4WDqxJP34yj7HhQaIcFrdNF2pnyTDK2/4u5e1yiq pRNrGC2riNb2uMTq5vuyLEN2qoBFXHchKJVzv/9FbuwUgtwVfyNbycQFDZsStZvSYBps CWv396nNxgQcmnI9Z4HX3BScKwQeMMwV4raq84Ed+wYV8X86awtNhg6OIrUHKilhrpnp HAJsWNYCdnY5poDof3D9+3zQiGwy+uhOennpcIUco2c2b2Zz3b00PEcEcmi1Vv1cCMrt jPnw== X-Gm-Message-State: AHQUAubthNrqfKDBGMRlIoopA6LecMmBzAOtL1K9p4skmNXpg/x0FBwU tMCA3q2b+brWe06RK+A0A5zCgAkZD+pSVA== X-Google-Smtp-Source: AHgI3IYsCPzU8eBhDsRnUAGA0lVJ1y7J/qtZ5f1lV1/mNuOAvrLXN1eqniDLGmu13k5UnfPV/+KoLg== X-Received: by 2002:a6b:dd04:: with SMTP id f4mr3406007ioc.248.1549475803938; Wed, 06 Feb 2019 09:56:43 -0800 (PST) Received: from [192.168.1.158] ([216.160.245.98]) by smtp.gmail.com with ESMTPSA id h64sm4175618itb.14.2019.02.06.09.56.41 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 06 Feb 2019 09:56:42 -0800 (PST) Subject: Re: [PATCH 13/18] io_uring: add file set registration To: Al Viro Cc: Jann Horn , linux-aio@kvack.org, linux-block@vger.kernel.org, Linux API , hch@lst.de, jmoyer@redhat.com, avi@scylladb.com, linux-fsdevel@vger.kernel.org References: <20190129192702.3605-1-axboe@kernel.dk> <20190129192702.3605-14-axboe@kernel.dk> <20190204025612.GR2217@ZenIV.linux.org.uk> <785c6db4-095e-65b0-ded5-72b41af5174e@kernel.dk> <2b2137ed-8107-f7b6-f0ca-202dcfb87c97@kernel.dk> <40b27e78-9ee8-1395-feb3-a73aac87c9a7@kernel.dk> <0d2e5085-32ff-e86e-d628-6000071fd132@kernel.dk> <20190206010104.GV2217@ZenIV.linux.org.uk> From: Jens Axboe Message-ID: <608c1102-5818-e38c-cfc7-b1cec5a1ecb4@kernel.dk> Date: Wed, 6 Feb 2019 10:56:41 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0 MIME-Version: 1.0 In-Reply-To: <20190206010104.GV2217@ZenIV.linux.org.uk> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 2/5/19 6:01 PM, Al Viro wrote: > On Tue, Feb 05, 2019 at 05:27:29PM -0700, Jens Axboe wrote: > >> This should be better, passes some basic testing, too: >> >> http://git.kernel.dk/cgit/linux-block/commit/?h=io_uring&id=01a93aa784319a02ccfa6523371b93401c9e0073 >> >> Verified that we're grabbing the right refs, and don't hold any >> ourselves. For the file registration, forbid registration of the >> io_uring fd, as that is pointless and will introduce a loop regardless >> of fd passing. > > *shrug* > > So pass it to AF_UNIX socket and register _that_ - does't change the > underlying problem. Maybe I'm being dense here, but it's an f_op match. Should catch a passed fd as well, correct? With that, how can there be a loop? -- Jens Axboe