From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from mx3-rdu2.redhat.com ([66.187.233.73]:49528 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP
        id S1726714AbeH0Aad (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Sun, 26 Aug 2018 20:30:33 -0400
From: David Howells <dhowells@redhat.com>
In-Reply-To: <5973.1535316177@warthog.procyon.org.uk>
References: <5973.1535316177@warthog.procyon.org.uk> <87va7xx15h.fsf@xmission.com> <20180823223145.GK6515@ZenIV.linux.org.uk>
Cc: dhowells@redhat.com, ebiederm@xmission.com (Eric W. Biederman),
        Al Viro <viro@ZenIV.linux.org.uk>,
        Linus Torvalds <torvalds@linux-foundation.org>,
        linux-fsdevel@vger.kernel.org, linux-api@vger.kernel.org
Subject: Re: [git pull] new mount API
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <6160.1535316413.1@warthog.procyon.org.uk>
Date: Sun, 26 Aug 2018 21:46:53 +0100
Message-ID: <6161.1535316413@warthog.procyon.org.uk>
To: unlisted-recipients:; (no To-header on input)
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

David Howells <dhowells@redhat.com> wrote:

> > ... we have bugs in the implementation.
> 
> Allegedly.  It would be useful if you could've pointed out what it was that
> you think you see.  I don't see offhand what it reintroduces.

This?

-	ns->mq_mnt = kern_mount_data(&mqueue_fs_type, ns, 0);
-	if (IS_ERR(ns->mq_mnt)) {
-		int err = PTR_ERR(ns->mq_mnt);
-		ns->mq_mnt = NULL;
-		return err;
-	}
+	m = mq_create_mount(&init_ipc_ns);
+	if (IS_ERR(m))
+		return PTR_ERR(m);
+	ns->mq_mnt = m;

Should be passing ns into mq_create_mount() rather than init_ipc_ns maybe?

David