From: John Hubbard <jhubbard@nvidia.com>
To: Matthew Wilcox <willy@infradead.org>,
David Howells <dhowells@redhat.com>
Cc: <viro@zeniv.linux.org.uk>, <linux-mm@vger.kernel.org>,
<linux-fsdevel@vger.kernel.org>, Christoph Hellwig <hch@lst.de>,
<smfrench@gmail.com>, <torvalds@linux-foundation.org>,
<linux-cifs@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor
Date: Mon, 31 Oct 2022 13:46:07 -0700 [thread overview]
Message-ID: <61e7810f-97e2-1185-312a-d096b5b2bced@nvidia.com> (raw)
In-Reply-To: <Y1/hSO+7kAJhGShG@casper.infradead.org>
On 10/31/22 07:52, Matthew Wilcox wrote:
> On Mon, Oct 31, 2022 at 02:49:32PM +0000, David Howells wrote:
>> I added a macro by which you can query an iterator to find out how the
>> extraction function will treat the pages (it returns 0, FOLL_GET or FOLL_PIN
>> as appropriate). Note that it's a macro to avoid #inclusion of linux/mm.h in
>> linux/uio.h.
>
> I'd support moving FOLL_* definitions to mm_types.h along with
> FAULT_FLAG_* and VM_FAULT_*.
+1, great idea. The use of FOLL_* without including it's .h directly was
the first thing that jumped out at me when I just started looking at
this. And these really are mm types, so yes.
thanks,
--
John Hubbard
NVIDIA
prev parent reply other threads:[~2022-10-31 20:46 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 14:49 [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor David Howells
2022-10-31 14:49 ` [RFC PATCH 1/2] iov_iter: Add a function to extract a page list from an iterator David Howells
2022-10-31 14:52 ` [RFC PATCH 0/2] iov_iter: Provide a function to extract/pin/get pages from an iteraor Matthew Wilcox
2022-10-31 20:46 ` John Hubbard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=61e7810f-97e2-1185-312a-d096b5b2bced@nvidia.com \
--to=jhubbard@nvidia.com \
--cc=dhowells@redhat.com \
--cc=hch@lst.de \
--cc=linux-cifs@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@vger.kernel.org \
--cc=smfrench@gmail.com \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).