From: Leonardo Bras <leonardo@linux.ibm.com>
To: linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH 1/1] fs/splice.c: Fix old documentation about moving pages
Date: Fri, 16 Aug 2019 14:24:52 -0300 [thread overview]
Message-ID: <631f282f177871a0961d25f3afc98b4b805436e7.camel@linux.ibm.com> (raw)
In-Reply-To: <52a42a7ab5052c7d35c98bca6439ff00e323a947.camel@linux.ibm.com>
[-- Attachment #1: Type: text/plain, Size: 1240 bytes --]
On Thu, 2019-08-08 at 15:19 -0300, Leonardo Bras wrote:
> On Thu, 2019-08-01 at 19:38 -0300, Leonardo Bras wrote:
> > Since commit 485ddb4b9741 ("1/2 splice: dont steal")' (2007),
> > the SPLICE_F_MOVE support was removed (became a no-op according
> > to man pages), and thus disabling steal operation that would make
> > moving pages possible.
> >
> > This fixes the comment, making clear pages are not moved.
> >
> > Signed-off-by: Leonardo Bras <leonardo@linux.ibm.com>
> > ---
> > fs/splice.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/fs/splice.c b/fs/splice.c
> > index 14cb602d9a2f..0ba151c40cef 100644
> > --- a/fs/splice.c
> > +++ b/fs/splice.c
> > @@ -671,8 +671,7 @@ ssize_t splice_from_pipe(struct pipe_inode_info *pipe, struct file *out,
> > * @flags: splice modifier flags
> > *
> > * Description:
> > - * Will either move or copy pages (determined by @flags options) from
> > - * the given pipe inode to the given file.
> > + * Will copy pages from the given pipe inode to the given file.
> > * This one is ->write_iter-based.
> > *
> > */
>
> Could you give any feedback on this patch?
Please provide feedback on this patch
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]
prev parent reply other threads:[~2019-08-16 17:25 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-08-01 22:38 [PATCH 1/1] fs/splice.c: Fix old documentation about moving pages Leonardo Bras
2019-08-08 18:19 ` Leonardo Bras
2019-08-16 17:24 ` Leonardo Bras [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=631f282f177871a0961d25f3afc98b4b805436e7.camel@linux.ibm.com \
--to=leonardo@linux.ibm.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).