Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
* [PATCH] fuse: fix inode rwsem regression
@ 2020-02-01  5:49 qiwuchen55
  2020-02-01 15:47 ` Matthew Wilcox
  2020-02-01 23:09 ` Bernd Schubert
  0 siblings, 2 replies; 7+ messages in thread
From: qiwuchen55 @ 2020-02-01  5:49 UTC (permalink / raw)
  To: miklos; +Cc: linux-fsdevel, chenqiwu

From: chenqiwu <chenqiwu@xiaomi.com>

Apparently our current rwsem code doesn't like doing the trylock, then
lock for real scheme.  So change our direct write method to just do the
trylock for the RWF_NOWAIT case.
This seems to fix AIM7 regression in some scalable filesystems upto ~25%
in some cases. Claimed in commit 942491c9e6d6 ("xfs: fix AIM7 regression")

Signed-off-by: chenqiwu <chenqiwu@xiaomi.com>
---
 fs/fuse/file.c | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/fs/fuse/file.c b/fs/fuse/file.c
index ce71538..ac16994 100644
--- a/fs/fuse/file.c
+++ b/fs/fuse/file.c
@@ -1529,7 +1529,13 @@ static ssize_t fuse_direct_write_iter(struct kiocb *iocb, struct iov_iter *from)
 	ssize_t res;
 
 	/* Don't allow parallel writes to the same file */
-	inode_lock(inode);
+	if (iocb->ki_flags & IOCB_NOWAIT) {
+		if (!inode_trylock(inode))
+			return -EAGAIN;
+	} else {
+		inode_lock(inode);
+	}
+
 	res = generic_write_checks(iocb, from);
 	if (res > 0) {
 		if (!is_sync_kiocb(iocb) && iocb->ki_flags & IOCB_DIRECT) {
-- 
1.9.1


^ permalink raw reply	[flat|nested] 7+ messages in thread

end of thread, back to index

Thread overview: 7+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-02-01  5:49 [PATCH] fuse: fix inode rwsem regression qiwuchen55
2020-02-01 15:47 ` Matthew Wilcox
2020-02-01 23:09 ` Bernd Schubert
2020-02-02  2:08   ` chenqiwu
2020-02-02 21:18     ` Bernd Schubert
2020-02-03  3:20       ` chenqiwu
2020-02-13  9:50       ` Miklos Szeredi

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git