From: Markus Elfring <Markus.Elfring@web.de>
To: Dan Carpenter <dan.carpenter@oracle.com>, linux-fsdevel@vger.kernel.org
Cc: kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org,
"Namjae Jeon" <namjae.jeon@samsung.com>,
"Sungjong Seo" <sj1557.seo@samsung.com>,
"Pali Rohár" <pali@kernel.org>,
"Tetsuhiro Kohada" <kohada.t2@gmail.com>,
"Wei Yongjun" <weiyongjun1@huawei.com>
Subject: Re: [PATCH] exfat: call brelse() on error path
Date: Wed, 10 Jun 2020 14:07:39 +0200 [thread overview]
Message-ID: <6939014a-adbf-f970-2541-df16d35de7e5@web.de> (raw)
> If the second exfat_get_dentry() call fails then we need to release
> "old_bh" before returning.
Thanks you picked a bit of information up from my source code analysis
for a possible adjustment of the function “exfat_rename_file”.
exfat: Improving exception handling in two functions
https://lore.kernel.org/linux-fsdevel/208cba7b-e535-c8e0-5ac7-f15170117a7f@web.de/
https://lkml.org/lkml/2020/6/10/272
Would you like to adjust the implementation of the function “exfat_move_file”
in a similar way in a subsequent patch variant?
Regards,
Markus
next reply other threads:[~2020-06-10 12:08 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-10 12:07 Markus Elfring [this message]
2020-06-10 17:22 ` [PATCH v2] exfat: add missing brelse() calls on error paths Dan Carpenter
2020-06-10 18:12 ` Markus Elfring
2020-06-10 18:45 ` Dan Carpenter
2020-06-10 18:56 ` Markus Elfring
2020-06-10 19:22 ` Matthew Wilcox
2020-06-10 20:00 ` Markus Elfring
2020-06-11 3:41 ` [PATCH v2] " Namjae Jeon
2020-06-11 8:00 ` Markus Elfring
2020-06-11 8:40 ` Markus Elfring
-- strict thread matches above, loose matches on Subject: below --
2020-06-10 9:27 exfat: Improving exception handling in two functions Markus Elfring
2020-06-10 9:59 ` [PATCH] exfat: call brelse() on error path Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=6939014a-adbf-f970-2541-df16d35de7e5@web.de \
--to=markus.elfring@web.de \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kohada.t2@gmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=namjae.jeon@samsung.com \
--cc=pali@kernel.org \
--cc=sj1557.seo@samsung.com \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).