From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 392F7C3A5A9 for ; Mon, 4 May 2020 16:42:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 11B3920721 for ; Mon, 4 May 2020 16:42:04 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=kernel-dk.20150623.gappssmtp.com header.i=@kernel-dk.20150623.gappssmtp.com header.b="F1xfOa3k" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729702AbgEDQl7 (ORCPT ); Mon, 4 May 2020 12:41:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44580 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729310AbgEDQl6 (ORCPT ); Mon, 4 May 2020 12:41:58 -0400 Received: from mail-il1-x143.google.com (mail-il1-x143.google.com [IPv6:2607:f8b0:4864:20::143]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8E1EDC061A0E for ; Mon, 4 May 2020 09:41:57 -0700 (PDT) Received: by mail-il1-x143.google.com with SMTP id x2so11866399ilp.13 for ; Mon, 04 May 2020 09:41:57 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=kernel-dk.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=o+OExAmgyirreBNQZz1mdzV+UOlsl91T24IoRPDTUCA=; b=F1xfOa3kXWTYolMLtey19TxDsFE0OVOmGFGXXfzZzeHq6Gq2eYJNzidg0G69JvwZY8 lVv/XrEzU8O49UtzvJe6YqyZi7d3+ayYhbnmazX9FZvG1VpGuTYl/CTkfWWGxw7dxKGX 8RB1X5d0fInxVY/9CA/mbxNjIYPCO85Vj5z2ChREefZA8zvo0a7ptA3YRya/4ZmucFwO D/MG+YTf8WvACUS2237dItdL+U9M7unu3NRWe7Fltx72XWkqwz2qMlWSP3E5XlCnBGx9 DK9KMNtHed00BpweFl5P8s9V8xDsWysRZrUsyMAYHKjgxAvyG0OJE2rhI37J0GsBKNhm nwjA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=o+OExAmgyirreBNQZz1mdzV+UOlsl91T24IoRPDTUCA=; b=Gyt1hHxM8sGRzMYdbnFJ51uKlXdIEFNZJrRCx5P3mQ5kV9mZyp2FpMxYQWbBN6If8O 0q2pWLg2pb0/GYxE+EDwU0zh2VneKzRpvT/bgxyf2TrOV74y1VCDW3nJHl0rsrCTtL4+ TRjFNekkpwxVI2qRU02viIf+TlyV6oCSq4p1VrRexbe65spuOh1Xa9PQWAPEe3ozCs9p jY+hG+SOuQblGiSDj8rz4KM8yRAsMHoealf80hgZwWMcUyHz3sS0B3SLPXYM1KUGQX8P Dk/5bjsQ6oHhJsdjD+JzEnY8YJjZGLGXttY/2ubgEuZKYhdYdrQ2+9LlIbRKOk29w/FX jJfg== X-Gm-Message-State: AGi0PuZD8hRw8kPSWDcTP0HCCIU7NISIsKLFjASaQQVO4xEekIWbttGd kVlMChAawe+oWzzlbZCzKM+VGw== X-Google-Smtp-Source: APiQypK3isUqB2C2sabeTTpk6n8V8noFEi6QUtgDDorDERlY5R+gZMBGol53QwqsH9zC6HzIIbmnWg== X-Received: by 2002:a92:41c6:: with SMTP id o189mr16632128ila.157.1588610516971; Mon, 04 May 2020 09:41:56 -0700 (PDT) Received: from [192.168.1.159] ([65.144.74.34]) by smtp.gmail.com with ESMTPSA id t88sm5381273ild.30.2020.05.04.09.41.55 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 04 May 2020 09:41:56 -0700 (PDT) Subject: Re: [PATCH 5/7] hfsplus: stop using ioctl_by_bdev To: Christoph Hellwig Cc: Tim Waugh , Borislav Petkov , Jan Kara , linux-block@vger.kernel.org, linux-ide@vger.kernel.org, linux-scsi@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org, Damien Le Moal References: <20200425075706.721917-1-hch@lst.de> <20200425075706.721917-6-hch@lst.de> <6c47f731-7bff-f186-da55-7ce6cffacdc3@kernel.dk> <20200504162114.GA637@lst.de> From: Jens Axboe Message-ID: <6cbb8166-a419-9322-78ee-51fbec22b59d@kernel.dk> Date: Mon, 4 May 2020 10:41:55 -0600 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.7.0 MIME-Version: 1.0 In-Reply-To: <20200504162114.GA637@lst.de> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 5/4/20 10:21 AM, Christoph Hellwig wrote: > On Mon, May 04, 2020 at 10:16:40AM -0600, Jens Axboe wrote: >> On 4/25/20 1:57 AM, Christoph Hellwig wrote: >>> if (HFSPLUS_SB(sb)->session >= 0) { >>> + struct cdrom_tocentry te; >>> + >>> + if (!cdi) >>> + return -EINVAL; >>> + >>> te.cdte_track = HFSPLUS_SB(sb)->session; >>> te.cdte_format = CDROM_LBA; >>> - res = ioctl_by_bdev(sb->s_bdev, >>> - CDROMREADTOCENTRY, (unsigned long)&te); >>> - if (!res && (te.cdte_ctrl & CDROM_DATA_TRACK) == 4) { >>> - *start = (sector_t)te.cdte_addr.lba << 2; >>> - return 0; >>> + if (cdrom_read_tocentry(cdi, &te) || >>> + (te.cdte_ctrl & CDROM_DATA_TRACK) != 4) { >>> + pr_err("invalid session number or type of track\n"); >>> + return -EINVAL; >>> } >> >> I must be missing something obvious from just looking over the patches, >> but how does this work if cdrom is modular and hfsplus is builtin? > > In that case disk_to_cdi will return NULL as it uses IS_REACHABLE > and the file systems won't query the CD-ROM specific information. Got it, looks like that'll do the trick without nasty Kconfig dependencies. -- Jens Axboe