linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Ilya Matveychikov <matvejchikov@gmail.com>
To: dsterba@suse.cz
Cc: Al Viro <viro@ZenIV.linux.org.uk>,
	linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] ksys_mount: check for permissions before resource allocation
Date: Tue, 5 Jun 2018 16:42:38 +0400	[thread overview]
Message-ID: <707FB500-5592-45B8-9279-36BE74CDBBCE@gmail.com> (raw)
In-Reply-To: <20180605122829.y4vicefcfvzpqraw@twin.jikos.cz>


> On Jun 5, 2018, at 4:28 PM, David Sterba <dsterba@suse.cz> wrote:
> 
>> BTW, sys_umount() has this check in the right place - before doing anything.
>> So, why not to have the same logic for mount/umount?
> 
> What if the check is not equivalent to the one done later? may_mount
> needs namespace, it will be available at umount time but not necessarily
> during mount due to the security hooks.

Might be the issue, you’re right. I can’t tell it for sure as I’m not so
familiar with linux/fs code.

  reply	other threads:[~2018-06-05 12:42 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <D2317950-0DB0-4311-ADB1-FF677B676E04@gmail.com>
2018-06-05  6:59 ` [PATCH] ksys_mount: check for permissions before resource allocation Ilya Matveychikov
2018-06-05 11:26   ` Al Viro
2018-06-05 11:35     ` Ilya Matveychikov
2018-06-05 11:53       ` Al Viro
2018-06-05 12:07         ` Ilya Matveychikov
2018-06-05 12:28           ` David Sterba
2018-06-05 12:42             ` Ilya Matveychikov [this message]
2018-06-05 12:34           ` Al Viro
2018-06-05 19:56   ` Eric W. Biederman
2018-06-06  9:32     ` Ilya Matveychikov
2018-06-06 14:22       ` Eric W. Biederman
2018-06-06 15:26         ` Ilya Matveychikov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=707FB500-5592-45B8-9279-36BE74CDBBCE@gmail.com \
    --to=matvejchikov@gmail.com \
    --cc=dsterba@suse.cz \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@ZenIV.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).