From: 王贇 <yun.wang@linux.alibaba.com>
To: "Randy Dunlap" <rdunlap@infradead.org>,
"Ingo Molnar" <mingo@redhat.com>,
"Peter Zijlstra" <peterz@infradead.org>,
"Juri Lelli" <juri.lelli@redhat.com>,
"Vincent Guittot" <vincent.guittot@linaro.org>,
"Dietmar Eggemann" <dietmar.eggemann@arm.com>,
"Steven Rostedt" <rostedt@goodmis.org>,
"Ben Segall" <bsegall@google.com>, "Mel Gorman" <mgorman@suse.de>,
"Luis Chamberlain" <mcgrof@kernel.org>,
"Kees Cook" <keescook@chromium.org>,
"Iurii Zaikin" <yzaikin@google.com>,
"Michal Koutný" <mkoutny@suse.com>,
linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-doc@vger.kernel.org,
"Paul E. McKenney" <paulmck@linux.ibm.com>
Subject: Re: [PATCH v2 3/3] sched/numa: documentation for per-cgroup numa stat
Date: Wed, 27 Nov 2019 13:54:11 +0800
Message-ID: <7169fba4-220f-a4a7-d6e7-0f025a3cd308@linux.alibaba.com> (raw)
In-Reply-To: <9ce01935-84ba-e8b4-461b-8be388433950@infradead.org>
Hi, Randy
On 2019/11/27 下午12:58, Randy Dunlap wrote:
> On 11/26/19 5:50 PM, 王贇 wrote:
>> Since v1:
>> * thanks to Iurii for the better sentence
>> * thanks to Jonathan for the better format
>>
>> Add the description for 'cg_numa_stat', also a new doc to explain
>> the details on how to deal with the per-cgroup numa statistics.
>>
>> Cc: Peter Zijlstra <peterz@infradead.org>
>> Cc: Michal Koutný <mkoutny@suse.com>
>> Cc: Mel Gorman <mgorman@suse.de>
>> Cc: Jonathan Corbet <corbet@lwn.net>
>> Cc: Iurii Zaikin <yzaikin@google.com>
>> Signed-off-by: Michael Wang <yun.wang@linux.alibaba.com>
>
> Hi,
> I have a few comments/corrections. Please see below.
Thanks for the comments :-) will apply them all in next version.
>
>> ---
>> Documentation/admin-guide/cg-numa-stat.rst | 163
[snip]
>> +if you want to have the whole history.
>> +
>> +We have per-task migfailed counter to tell how many page migration has been
>
> I can't find any occurrence of 'migfailed' in the entire kernel source tree.
> Maybe it is misspelled?
This one is added by the secondary patch:
[PATCH v2 2/3] sched/numa: expose per-task pages-migration-failure
As suggested by Mel.
Regards,
Michael Wang
>
>> +failed for a particular task, you will find it in /proc/PID/sched entry.
>
>
> HTH.
>
next prev parent reply index
Thread overview: 66+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-11-13 3:43 [PATCH 0/3] sched/numa: introduce advanced numa statistic 王贇
2019-11-13 3:44 ` [PATCH 1/3] sched/numa: advanced per-cgroup " 王贇
2019-11-13 3:45 ` [PATCH 2/3] sched/numa: expose per-task pages-migration-failure 王贇
2019-11-13 3:45 ` [PATCH 3/3] sched/numa: documentation for per-cgroup numa stat 王贇
2019-11-13 15:09 ` Jonathan Corbet
2019-11-14 1:52 ` 王贇
2019-11-13 18:28 ` Iurii Zaikin
2019-11-14 2:22 ` 王贇
2019-11-15 2:29 ` [PATCH v2 " 王贇
2019-11-20 9:45 ` [PATCH 0/3] sched/numa: introduce advanced numa statistic 王贇
2019-11-25 1:35 ` 王贇
2019-11-27 1:48 ` [PATCH v2 " 王贇
2019-11-27 1:49 ` [PATCH v2 1/3] sched/numa: advanced per-cgroup " 王贇
2019-11-27 10:19 ` Mel Gorman
2019-11-28 2:09 ` 王贇
2019-11-28 12:39 ` Michal Koutný
2019-11-28 13:41 ` 王贇
2019-11-28 15:58 ` Michal Koutný
2019-11-29 1:52 ` 王贇
2019-11-29 5:19 ` 王贇
2019-11-29 10:06 ` Michal Koutný
2019-12-02 2:11 ` 王贇
2019-11-27 1:50 ` [PATCH v2 2/3] sched/numa: expose per-task pages-migration-failure 王贇
2019-11-27 10:00 ` Mel Gorman
2019-12-02 2:22 ` 王贇
2019-11-27 1:50 ` [PATCH v2 3/3] sched/numa: documentation for per-cgroup numa stat 王贇
2019-11-27 4:58 ` Randy Dunlap
2019-11-27 5:54 ` 王贇 [this message]
2019-12-03 5:59 ` [PATCH v3 0/2] sched/numa: introduce numa locality 王贇
2019-12-03 6:00 ` [PATCH v3 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2019-12-04 2:33 ` Randy Dunlap
2019-12-04 2:38 ` 王贇
2019-12-03 6:02 ` [PATCH v3 2/2] sched/numa: documentation for per-cgroup numa statistics 王贇
2019-12-03 13:43 ` Jonathan Corbet
2019-12-04 2:27 ` 王贇
2019-12-04 7:58 ` [PATCH v4 0/2] sched/numa: introduce numa locality 王贇
2019-12-04 7:59 ` [PATCH v4 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2019-12-05 3:28 ` Randy Dunlap
2019-12-05 3:29 ` Randy Dunlap
2019-12-05 3:52 ` 王贇
2019-12-04 8:00 ` [PATCH v4 2/2] sched/numa: documentation for per-cgroup numa statistics 王贇
2019-12-05 3:40 ` Randy Dunlap
2019-12-05 6:53 ` [PATCH v5 0/2] sched/numa: introduce numa locality 王贇
2019-12-05 6:53 ` [PATCH v5 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2019-12-05 6:54 ` [PATCH v5 2/2] sched/numa: documentation for per-cgroup numa, statistics 王贇
2019-12-10 2:19 ` [PATCH v5 0/2] sched/numa: introduce numa locality 王贇
2019-12-13 1:43 ` [PATCH v6 " 王贇
2019-12-13 1:47 ` [PATCH v6 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2020-01-03 15:14 ` Michal Koutný
2020-01-04 4:51 ` 王贇
2019-12-13 1:48 ` [PATCH v6 2/2] sched/numa: documentation for per-cgroup numa 王贇
2019-12-27 2:22 ` [PATCH v6 0/2] sched/numa: introduce numa locality 王贇
2020-01-17 2:19 ` 王贇
2020-01-19 6:08 ` [PATCH v7 " 王贇
2020-01-19 6:09 ` [PATCH v7 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2020-01-19 6:09 ` [PATCH v7 2/2] sched/numa: documentation for per-cgroup numa, statistics 王贇
2020-01-21 0:12 ` Randy Dunlap
2020-01-21 1:58 ` 王贇
2020-01-21 1:56 ` [PATCH v8 0/2] sched/numa: introduce numa locality 王贇
2020-01-21 1:57 ` [PATCH v8 1/2] sched/numa: introduce per-cgroup NUMA locality info 王贇
2020-01-21 1:57 ` [PATCH v8 2/2] sched/numa: documentation for per-cgroup numa, statistics 王贇
2020-01-21 2:08 ` Randy Dunlap
2020-02-07 1:10 ` [PATCH v8 0/2] sched/numa: introduce numa locality 王贇
2020-02-07 1:25 ` Steven Rostedt
2020-02-07 2:31 ` 王贇
2020-02-07 2:37 ` [PATCH RESEND " 王贇
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7169fba4-220f-a4a7-d6e7-0f025a3cd308@linux.alibaba.com \
--to=yun.wang@linux.alibaba.com \
--cc=bsegall@google.com \
--cc=dietmar.eggemann@arm.com \
--cc=juri.lelli@redhat.com \
--cc=keescook@chromium.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mcgrof@kernel.org \
--cc=mgorman@suse.de \
--cc=mingo@redhat.com \
--cc=mkoutny@suse.com \
--cc=paulmck@linux.ibm.com \
--cc=peterz@infradead.org \
--cc=rdunlap@infradead.org \
--cc=rostedt@goodmis.org \
--cc=vincent.guittot@linaro.org \
--cc=yzaikin@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Linux-Fsdevel Archive on lore.kernel.org
Archives are clonable:
git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git
# If you have public-inbox 1.1+ installed, you may
# initialize and index your mirror using the following commands:
public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
linux-fsdevel@vger.kernel.org
public-inbox-index linux-fsdevel
Example config snippet for mirrors
Newsgroup available over NNTP:
nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel
AGPL code for this site: git clone https://public-inbox.org/public-inbox.git