From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.kernel.org ([198.145.29.99]:36622 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbdKWNFa (ORCPT ); Thu, 23 Nov 2017 08:05:30 -0500 Subject: Re: [PATCH v3 RESEND] f2fs: add bug_on when f2fs_gc even fails to get one victim To: Yunlong Song , jaegeuk@kernel.org, yuchao0@huawei.com, yunlong.song@icloud.com Cc: miaoxie@huawei.com, bintian.wang@huawei.com, linux-fsdevel@vger.kernel.org, linux-f2fs-devel@lists.sourceforge.net, linux-kernel@vger.kernel.org References: <1510880948-154538-1-git-send-email-yunlong.song@huawei.com> From: Chao Yu Message-ID: <77657045-2bba-2c31-f668-de6351c3f342@kernel.org> Date: Thu, 23 Nov 2017 21:05:12 +0800 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 2017/11/22 11:50, Yunlong Song wrote: > ping again... > > On 2017/11/17 9:09, Yunlong Song wrote: >> This can help to find potential bugs on some corner case. Could you test this patch with fstest suit? if there are any testcases can trigger this bug_on, it will be better to fix them all together. Thanks, >> >> Signed-off-by: Yunlong Song >> --- >>   fs/f2fs/gc.c | 1 + >>   1 file changed, 1 insertion(+) >> >> diff --git a/fs/f2fs/gc.c b/fs/f2fs/gc.c >> index 5d5bba4..c89128b 100644 >> --- a/fs/f2fs/gc.c >> +++ b/fs/f2fs/gc.c >> @@ -1035,6 +1035,7 @@ int f2fs_gc(struct f2fs_sb_info *sbi, bool sync, >>           goto stop; >>       } >>       if (!__get_victim(sbi, &segno, gc_type)) { >> +        f2fs_bug_on(sbi, !total_freed && has_not_enough_free_secs(sbi, 0, 0)); >>           ret = -ENODATA; >>           goto stop; >>       } >