From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 10E87C6FD1D for ; Thu, 30 Mar 2023 09:30:01 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230094AbjC3JaA (ORCPT ); Thu, 30 Mar 2023 05:30:00 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:56352 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230016AbjC3J37 (ORCPT ); Thu, 30 Mar 2023 05:29:59 -0400 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 4FD007693 for ; Thu, 30 Mar 2023 02:29:17 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1680168556; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=+XgWAMkX5gl81w36XkfWKNCMFULxOFJmmzo6Xs6xITY=; b=VyxB1NNhEjH7AWD1MbEBKslgSyYpUSp5adkL4tMexfkhgWiiPhOB4nqlORqhrTog/JXJoT 2GlNw0o8u2L3iC5jFQWSObYr+cnP4foLvYEgxtIPde4nh1KX9gkASmhRhIf3ZQ6lBhV2Em bTQVmbCyDGTD2O+N45hsZ7EbZmcFi+Q= Received: from mimecast-mx02.redhat.com (mimecast-mx02.redhat.com [66.187.233.88]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id us-mta-544-jczfNWu4OtqMRHX0J7vacA-1; Thu, 30 Mar 2023 05:29:11 -0400 X-MC-Unique: jczfNWu4OtqMRHX0J7vacA-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.rdu2.redhat.com [10.11.54.2]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 8C7768828CB; Thu, 30 Mar 2023 09:29:10 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.33.36.18]) by smtp.corp.redhat.com (Postfix) with ESMTP id BE8D34020C82; Thu, 30 Mar 2023 09:29:07 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> References: <6F2985FF-2474-4F36-BD94-5F8E97E46AC2@oracle.com> <20230329141354.516864-1-dhowells@redhat.com> <20230329141354.516864-41-dhowells@redhat.com> To: Chuck Lever III Cc: dhowells@redhat.com, Matthew Wilcox , "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Al Viro , Christoph Hellwig , Jens Axboe , Jeff Layton , Christian Brauner , Linus Torvalds , "open list:NETWORKING [GENERAL]" , linux-fsdevel , Linux Kernel Mailing List , Linux Memory Management List , Trond Myklebust , Anna Schumaker , Linux NFS Mailing List Subject: Re: [RFC PATCH v2 40/48] sunrpc: Use sendmsg(MSG_SPLICE_PAGES) rather then sendpage MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <777294.1680168547.1@warthog.procyon.org.uk> Date: Thu, 30 Mar 2023 10:29:07 +0100 Message-ID: <777295.1680168547@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 3.1 on 10.11.54.2 Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Chuck Lever III wrote: > It seems to me that you could eliminate the kernel_sendpage() > consumer here in svc_tcp_sendmsg() without also replacing the > kernel_sendmsg() calls. That would be a conservative step-wise > approach which would carry less risk, and would accomplish > your stated goal without more radical surgery. Note that only the marker is sent with kernel_sendmsg() in the unmodified code; the head and tail are sent with svc_tcp_send_kvec()... which uses kernel_sendpage() which needs to be changed in my patchset. I can make it do individual sendmsg calls for all those for now. David