From: Wu Bo <wubo40@huawei.com>
To: <miklos@szeredi.hu>, <linux-fsdevel@vger.kernel.org>,
<linux-kernel@vger.kernel.org>
Cc: <linfeilong@huawei.com>
Subject: Re: [PATCH] fuse: use DIV_ROUND_UP helper macro for calculations
Date: Tue, 1 Jun 2021 14:10:10 +0800 [thread overview]
Message-ID: <79744e88-7f72-ce71-c379-cf749a6ba2f4@huawei.com> (raw)
In-Reply-To: <1621928447-456653-1-git-send-email-wubo40@huawei.com>
ping ...
On 2021/5/25 15:40, Wu Bo wrote:
> From: Wu Bo <wubo40@huawei.com>
>
> Replace open coded divisor calculations with the DIV_ROUND_UP kernel
> macro for better readability.
>
> Signed-off-by: Wu Bo <wubo40@huawei.com>
> ---
> fs/fuse/file.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/fs/fuse/file.c b/fs/fuse/file.c
> index 09ef2a4..62443eb 100644
> --- a/fs/fuse/file.c
> +++ b/fs/fuse/file.c
> @@ -1405,7 +1405,7 @@ static int fuse_get_user_pages(struct fuse_args_pages *ap, struct iov_iter *ii,
> nbytes += ret;
>
> ret += start;
> - npages = (ret + PAGE_SIZE - 1) / PAGE_SIZE;
> + npages = DIV_ROUND_UP(ret, PAGE_SIZE);
>
> ap->descs[ap->num_pages].offset = start;
> fuse_page_descs_length_init(ap->descs, ap->num_pages, npages);
>
next prev parent reply other threads:[~2021-06-01 6:10 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-25 7:40 [PATCH] fuse: use DIV_ROUND_UP helper macro for calculations Wu Bo
2021-06-01 6:10 ` Wu Bo [this message]
2021-06-21 8:32 ` Miklos Szeredi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=79744e88-7f72-ce71-c379-cf749a6ba2f4@huawei.com \
--to=wubo40@huawei.com \
--cc=linfeilong@huawei.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miklos@szeredi.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).