From: Randy Dunlap <rdunlap@infradead.org>
To: Colton Lewis <colton.w.lewis@protonmail.com>, viro@zeniv.linux.org.uk
Cc: linux-fsdevel@vger.kernel.org
Subject: Re: [PATCH] fs: correct kernel-doc inconsistency
Date: Mon, 6 Jul 2020 22:13:07 -0700 [thread overview]
Message-ID: <7b57c3a0-a41f-4b97-e0c9-d902abf8ae89@infradead.org> (raw)
In-Reply-To: <20200707044148.235087-1-colton.w.lewis@protonmail.com>
On 7/6/20 9:42 PM, Colton Lewis wrote:
> Silence documentation build warning by correcting kernel-doc comment
> for file_sample_sub_err function.
>
> ./include/linux/fs.h:2839: warning: Function parameter or member 'file' not described in 'file_sample_sb_err'
> ./include/linux/fs.h:2839: warning: Excess function parameter 'mapping' description in 'file_sample_sb_err'
>
> Signed-off-by: Colton Lewis <colton.w.lewis@protonmail.com>
Hi,
This is already fixed in linux-next.
You should check linux-next for anything that could already have patches
available but that have not been merged into mainline yet.
> ---
> include/linux/fs.h | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/include/linux/fs.h b/include/linux/fs.h
> index 3f881a892ea7..15f430c800dc 100644
> --- a/include/linux/fs.h
> +++ b/include/linux/fs.h
> @@ -2827,7 +2827,7 @@ static inline errseq_t filemap_sample_wb_err(struct address_space *mapping)
>
> /**
> * file_sample_sb_err - sample the current errseq_t to test for later errors
> - * @mapping: mapping to be sampled
> + * @file: file to be sampled
> *
> * Grab the most current superblock-level errseq_t value for the given
> * struct file.
>
thanks.
--
~Randy
prev parent reply other threads:[~2020-07-07 5:13 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-07 4:42 [PATCH] fs: correct kernel-doc inconsistency Colton Lewis
2020-07-07 5:13 ` Randy Dunlap [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=7b57c3a0-a41f-4b97-e0c9-d902abf8ae89@infradead.org \
--to=rdunlap@infradead.org \
--cc=colton.w.lewis@protonmail.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).