linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Anna Schumaker <Anna.Schumaker@Netapp.com>
To: Amir Goldstein <amir73il@gmail.com>,
	Goldwyn Rodrigues <rgoldwyn@suse.de>
Cc: linux-fsdevel <linux-fsdevel@vger.kernel.org>,
	Christoph Hellwig <hch@lst.de>,
	overlayfs <linux-unionfs@vger.kernel.org>,
	Dave Chinner <david@fromorbit.com>,
	Al Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH v2 0/4] Enable holes in copy_file_range()
Date: Thu, 10 May 2018 06:45:04 -0400	[thread overview]
Message-ID: <7c2bce28-9e55-f9bc-0212-bbd26b56a036@Netapp.com> (raw)
In-Reply-To: <CAOQ4uxiDi9fFGhXxWH-pvDDP-8rk9cmwedLcsid3L51KyP8fbA@mail.gmail.com>



On 05/10/2018 12:47 AM, Amir Goldstein wrote:
> On Thu, May 10, 2018 at 4:58 AM, Goldwyn Rodrigues <rgoldwyn@suse.de> wrote:
>> If copy_file_range performs a copy using splice, it converts holes
>> to zeros. This effort primarily changes this behavior to create
>> holes when it is possible.
>>
>> Even if copy_file_range() or clone_file_range() does not work for different
>> mounted filesystems, We should be able to splice files if they do not
>> belong the same super_block.
>>
>> Changes since v1:
>> - Fixed bug when hole/data offset is farther than len
> 
> Please specify how you tested this work.
> Did you run the xfstests generic/copy tests that Anna wrote?
> If the tests caught your bugs - good, if they didn't, please
> write more tests to cover the issues you found.
> One thing I do not see in the existing tests is coverage for the
> trivial case of "only holes" (i.e. touch x; truncate -s 10 x).

Yeah,  that's probably an oversight on my part.  I hadn't even thought about sparse files as I was writing those tests.  Please add tests for holes!

Anna

> 
> Thanks,
> Amir.
> 

      reply	other threads:[~2018-05-10 10:54 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-05-10  1:58 [PATCH v2 0/4] Enable holes in copy_file_range() Goldwyn Rodrigues
2018-05-10  1:58 ` [PATCH 1/4] copy_file_range: refactor vfs_copy_file_range Goldwyn Rodrigues
2018-05-10  1:58 ` [PATCH 2/4] copy_file_range: Perform splice if in/out SB are not same Goldwyn Rodrigues
2018-05-10  1:58 ` [PATCH 3/4] copy_file_range: splice with holes Goldwyn Rodrigues
2018-05-10  4:42   ` Amir Goldstein
2018-05-10  5:49     ` Amir Goldstein
2018-05-10  1:58 ` [PATCH 4/4] ovl: Use do_copy_file_range() in copy_up_data() Goldwyn Rodrigues
2018-05-10  4:47 ` [PATCH v2 0/4] Enable holes in copy_file_range() Amir Goldstein
2018-05-10 10:45   ` Anna Schumaker [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7c2bce28-9e55-f9bc-0212-bbd26b56a036@Netapp.com \
    --to=anna.schumaker@netapp.com \
    --cc=amir73il@gmail.com \
    --cc=david@fromorbit.com \
    --cc=hch@lst.de \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-unionfs@vger.kernel.org \
    --cc=rgoldwyn@suse.de \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).