Linux-Fsdevel Archive on lore.kernel.org
 help / color / Atom feed
From: Pavel Begunkov <asml.silence@gmail.com>
To: Christoph Hellwig <hch@infradead.org>
Cc: Alexander Viro <viro@zeniv.linux.org.uk>,
	linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] splice: direct call for default_file_splice*()
Date: Sun, 2 Aug 2020 11:49:54 +0300
Message-ID: <7eb5960a-4e92-a479-127d-6a0462e43e55@gmail.com> (raw)
In-Reply-To: <20200801174110.GA8535@infradead.org>

On 01/08/2020 20:41, Christoph Hellwig wrote:
> On Sat, Aug 01, 2020 at 01:12:22PM +0300, Pavel Begunkov wrote:
>> On 30/01/2020 19:54, Christoph Hellwig wrote:
>>> On Mon, Jan 20, 2020 at 11:49:46PM +0300, Pavel Begunkov wrote:
>>>> Indirect calls could be very expensive nowadays, so try to use direct calls
>>>> whenever possible.
>>
>> Hah, I'm surprised to find it as
>> 00c285d0d0fe4 ("fs: simplify do_splice_from").
>>
>> Christoph, even though this one is not a big deal, I'm finding the
>> practice of taking others patches and silently sending them as yours
>> own in general disgusting. Just for you to know.
> 
> Err, what makes you think I took your patch vs just not remembering
> and pointlessly doing the same cleanup again?  If I had rembered your
> patch I would have just added to the series with your credit as I've
> done for plenty other patches..

I have no intention of picking it to pieces or something, it doesn't
worth our time, and glad that's by accident, but you may guess how it
looks -- you commented on it, and after not being picked, the patch
reappears slightly rebranded.

-- 
Pavel Begunkov

      reply index

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-01-20 20:49 Pavel Begunkov
2020-01-30 16:54 ` Christoph Hellwig
2020-01-31  9:52   ` Pavel Begunkov
2020-08-01 10:12   ` Pavel Begunkov
2020-08-01 17:41     ` Christoph Hellwig
2020-08-02  8:49       ` Pavel Begunkov [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=7eb5960a-4e92-a479-127d-6a0462e43e55@gmail.com \
    --to=asml.silence@gmail.com \
    --cc=hch@infradead.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

Linux-Fsdevel Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/linux-fsdevel/0 linux-fsdevel/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 linux-fsdevel linux-fsdevel/ https://lore.kernel.org/linux-fsdevel \
		linux-fsdevel@vger.kernel.org
	public-inbox-index linux-fsdevel

Example config snippet for mirrors

Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-fsdevel


AGPL code for this site: git clone https://public-inbox.org/public-inbox.git