From: Randy Dunlap <rdunlap@infradead.org>
To: "Tobin C. Harding" <tobin@kernel.org>, Jonathan Corbet <corbet@lwn.net>
Cc: linux-doc@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 00/13] Convert vfs.txt to vfs.rst
Date: Sun, 17 Mar 2019 18:46:40 -0700 [thread overview]
Message-ID: <821449c9-e1f7-caa1-ff18-0cc1cc625596@infradead.org> (raw)
In-Reply-To: <20190313040919.6937-1-tobin@kernel.org>
On 3/12/19 9:09 PM, Tobin C. Harding wrote:
> Hi,
>
> This set converts the VFS overview documentation to RST format. I think
> I'm slowly getting better at structuring these conversions to ease
> review, if you disagree or you notice any way to further improve please
> say so.
Hi Tobin,
What does this patch set apply to? Maybe Jon's git tree?
I applied it to 5.1-rc1 with some forceful (minor) editing and ran
'make htmldocs' successfully, so
Tested-by: Randy Dunlap <rdunlap@infradead.org>
although there is at least one new field in struct file_operations: iopoll.
cheers.
> Patch set introduces no new warnings/errors to the html docs build
>
> $ make htmldocs 2> ../docs-pre-vfs.stderr
>
> Apply patch set
>
> $ make cleandocs
> $ make htmldocs 2> ../docs-post-vfs.stderr
> $ diff ../docs-pre-vfs.stderr ../docs-post-vfs.stderr
>
>
> Patch 1-4 - Whitespace fixes.
> Patch 5 - Adds the document title adornments (above and below)
> Patch 6 - Adds a SPDX license identifier
> Patch 7 - Fixes some custom indentation at the top of the file that will
> cause Sphinx to warn when we switch to .rst
> Patch 8 - Converts custom list format to use RST formatted lists, this
> is in preparation for switching to .rst
> Patch 9 - Adds '.. code-block:: c' and fixes indentation of code
> blocks. We rename the file to .rst in this patch (introducing
> some new warnings).
> Patch 10 - Adds back ticks to all the list items. This is in
> preparation for fixing the indentation in the next patch.
> This was found to help when reading both plain text and HTML.
> Patch 11 - Cleans up the lists, indentation and missing periods. This
> was kept separate to assist review. This patch is benign,
> the less meticulous reviewer could safely skip over this one
> quickly (this was the intention of separating these changes).
> Patch 12 - Fixes a few minor grammar mistakes I notice while reading the
> file, I'm taking bonus points for actually reading every word
> of the file and not just trying to haphazardly do the
> conversion like I have previously done :)
> Patch 13 - Fixes two remaining Sphinx warnings.
>
> If/when this goes in perhaps I, or someone else, will update the content
> to document a newer kernel version.
>
>
> thanks,
> Tobin.
>
>
> Tobin C. Harding (13):
> docs: filesystems: vfs: Remove space before tab
> docs: filesystems: vfs: Use uniform space after period.
> docs: filesystems: vfs: Use 72 character column width
> docs: filesystems: vfs: Use uniform spacing around headings
> docs: filesystems: vfs: Use correct initial heading
> docs: filesystems: vfs: Use SPDX identifier
> docs: filesystems: vfs: Fix pre-amble indentation
> docs: filesystems: vfs: Use list character for lists
> docs: filesystems: vfs: Add code-block and txt->RST
> docs: filesystems: vfs: Use ticks for listed items
> docs: filesystems: vfs: Clean up lists
> docs: filesystems: vfs: Do minor grammar fixes
> docs: filesystems: vfs: Use backticks to guard star
>
> Documentation/filesystems/index.rst | 1 +
> Documentation/filesystems/vfs.rst | 1279 +++++++++++++++++++++++++++
> Documentation/filesystems/vfs.txt | 1261 --------------------------
> 3 files changed, 1280 insertions(+), 1261 deletions(-)
> create mode 100644 Documentation/filesystems/vfs.rst
> delete mode 100644 Documentation/filesystems/vfs.txt
>
--
~Randy
next prev parent reply other threads:[~2019-03-18 1:46 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-13 4:09 [PATCH 00/13] Convert vfs.txt to vfs.rst Tobin C. Harding
2019-03-13 4:09 ` [PATCH 01/13] docs: filesystems: vfs: Remove space before tab Tobin C. Harding
2019-03-13 4:09 ` [PATCH 02/13] docs: filesystems: vfs: Use uniform space after period Tobin C. Harding
2019-03-13 4:09 ` [PATCH 03/13] docs: filesystems: vfs: Use 72 character column width Tobin C. Harding
2019-03-13 4:09 ` [PATCH 04/13] docs: filesystems: vfs: Use uniform spacing around headings Tobin C. Harding
2019-03-13 4:09 ` [PATCH 05/13] docs: filesystems: vfs: Use correct initial heading Tobin C. Harding
2019-03-13 4:09 ` [PATCH 06/13] docs: filesystems: vfs: Use SPDX identifier Tobin C. Harding
2019-03-13 4:09 ` [PATCH 07/13] docs: filesystems: vfs: Fix pre-amble indentation Tobin C. Harding
2019-03-13 4:09 ` [PATCH 08/13] docs: filesystems: vfs: Use list character for lists Tobin C. Harding
2019-03-13 4:09 ` [PATCH 09/13] docs: filesystems: vfs: Add code-block and txt->RST Tobin C. Harding
2019-03-13 4:09 ` [PATCH 10/13] docs: filesystems: vfs: Use ticks for listed items Tobin C. Harding
2019-03-13 4:09 ` [PATCH 11/13] docs: filesystems: vfs: Clean up lists Tobin C. Harding
2019-03-13 4:09 ` [PATCH 12/13] docs: filesystems: vfs: Do minor grammar fixes Tobin C. Harding
2019-03-13 4:09 ` [PATCH 13/13] docs: filesystems: vfs: Use backticks to guard star Tobin C. Harding
2019-03-18 1:46 ` Randy Dunlap [this message]
2019-03-18 3:34 ` [PATCH 00/13] Convert vfs.txt to vfs.rst Tobin C. Harding
2019-03-18 17:42 ` Jonathan Corbet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=821449c9-e1f7-caa1-ff18-0cc1cc625596@infradead.org \
--to=rdunlap@infradead.org \
--cc=corbet@lwn.net \
--cc=linux-doc@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tobin@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).