From: Tony Asleson <tasleson@redhat.com>
To: Matthew Wilcox <willy@infradead.org>
Cc: linux-scsi@vger.kernel.org, linux-block@vger.kernel.org,
linux-fsdevel@vger.kernel.org
Subject: Re: [RFC 1/9] lib/string: Add function to trim duplicate WS
Date: Thu, 2 Jan 2020 16:52:19 -0600 [thread overview]
Message-ID: <8392b726-fa55-baa4-6913-5ca0e4fa46a7@redhat.com> (raw)
In-Reply-To: <20191223232824.GB31820@bombadil.infradead.org>
On 12/23/19 5:28 PM, Matthew Wilcox wrote:
> On Mon, Dec 23, 2019 at 04:55:50PM -0600, Tony Asleson wrote:
>> +/**
>> + * Removes leading and trailing whitespace and removes duplicate
>> + * adjacent whitespace in a string, modifies string in place.
>> + * @s The %NUL-terminated string to have spaces removed
>> + * Returns the new length
>> + */
>
> This isn't good kernel-doc. See Documentation/doc-guide/kernel-doc.rst
> Compile with W=1 to get the format checked.
Indeed, I'll correct it.
>> +size_t strim_dupe(char *s)
>> +{
>> + size_t ret = 0;
>> + char *w = s;
>> + char *p;
>> +
>> + /*
>> + * This will remove all leading and duplicate adjacent, but leave
>> + * 1 space at the end if one or more are present.
>> + */
>> + for (p = s; *p != '\0'; ++p) {
>> + if (!isspace(*p) || (p != s && !isspace(*(p - 1)))) {
>> + *w = *p;
>> + ++w;
>> + ret += 1;
>> + }
>> + }
>
> I'd be tempted to do ...
>
> size_t ret = 0;
> char *w = s;
> bool last_space = false;
>
> do {
> bool this_space = isspace(*s);
>
> if (!this_space || !last_space) {
> *w++ = *s;
> ret++;
> }
> s++;
> last_space = this_space;
> } while (s[-1] != '\0');
That leaves a starting and trailing WS, how about something like this?
size_t strim_dupe(char *s)
{
size_t ret = 0;
char *w = s;
bool last_space = false;
do {
bool this_space = isspace(*s);
if (!this_space || (!last_space && ret)) {
*w++ = *s;
ret++;
}
s++;
last_space = this_space;
} while (s[-1] != '\0');
if (ret > 1 && isspace(w[-2])) {
w[-2] = '\0';
ret--;
}
ret--;
return ret;
}
Thanks
-Tony
next prev parent reply other threads:[~2020-01-02 22:52 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-12-23 22:55 [RFC 0/9] Add persistent durable identifier to storage log messages Tony Asleson
2019-12-23 22:55 ` [RFC 1/9] lib/string: Add function to trim duplicate WS Tony Asleson
2019-12-23 23:28 ` Matthew Wilcox
2020-01-02 22:52 ` Tony Asleson [this message]
2020-01-03 14:30 ` Tony Asleson
2019-12-23 22:55 ` [RFC 2/9] printk: Bring back printk_emit Tony Asleson
2019-12-23 22:55 ` [RFC 3/9] printk: Add printk_emit_ratelimited macro Tony Asleson
2019-12-23 22:55 ` [RFC 4/9] struct device_type: Add function callback durable_name Tony Asleson
2019-12-23 22:55 ` [RFC 5/9] block: Add support functions for persistent durable name Tony Asleson
2019-12-23 22:55 ` [RFC 6/9] create_syslog_header: Add " Tony Asleson
2019-12-24 0:54 ` James Bottomley
2020-01-02 22:53 ` Tony Asleson
2019-12-23 22:55 ` [RFC 7/9] print_req_error: Add persistent " Tony Asleson
2019-12-23 22:55 ` [RFC 8/9] ata_dev_printk: Add durable name to output Tony Asleson
2019-12-24 0:56 ` James Bottomley
2019-12-23 22:55 ` [RFC 9/9] __xfs_printk: " Tony Asleson
2020-01-04 2:56 ` Dave Chinner
2020-01-06 2:45 ` Tony Asleson
2020-01-06 22:02 ` Dave Chinner
2020-01-07 0:19 ` Sweet Tea Dorminy
2020-01-07 1:23 ` Dave Chinner
2020-01-07 17:01 ` Tony Asleson
2020-01-08 2:10 ` Dave Chinner
2020-01-08 16:53 ` Tony Asleson
2020-01-09 1:41 ` Alasdair G Kergon
2020-01-09 23:22 ` Dave Chinner
2020-01-10 1:28 ` Alasdair G Kergon
2020-01-10 16:13 ` Tony Asleson
2019-12-24 0:50 ` [RFC 0/9] Add persistent durable identifier to storage log messages James Bottomley
2020-01-02 22:52 ` Tony Asleson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8392b726-fa55-baa4-6913-5ca0e4fa46a7@redhat.com \
--to=tasleson@redhat.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=willy@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).