From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.5 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B94E9C433E0 for ; Fri, 22 Jan 2021 15:26:14 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 81CC423A84 for ; Fri, 22 Jan 2021 15:26:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728633AbhAVPZz (ORCPT ); Fri, 22 Jan 2021 10:25:55 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35888 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728872AbhAVPZT (ORCPT ); Fri, 22 Jan 2021 10:25:19 -0500 Received: from mail-qk1-x72f.google.com (mail-qk1-x72f.google.com [IPv6:2607:f8b0:4864:20::72f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6DF6CC061786 for ; Fri, 22 Jan 2021 07:24:35 -0800 (PST) Received: by mail-qk1-x72f.google.com with SMTP id c7so5441915qke.1 for ; Fri, 22 Jan 2021 07:24:35 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=toxicpanda-com.20150623.gappssmtp.com; s=20150623; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=62MG5B/ncqLFJMCPey88hP/CHS6L6DB9Q0Ol9XSuCU0=; b=eu+aytMOKIcLG7CoJGMlIIGYbOrANii2MOrd/d1r7QJJrjPiS8AS04T+mxYjh5ONo6 oPtTXJ+nhSi34vv5ql9Wo9fbBE1pIS0wY3ciONxzkt5Q3pNGyPiD5Xjzd+c/osFYomDF ZdrncByxIGpz/7XID5uF4JMYMpbtTkKDkGGkWE46h/EBIy2TZQDK3rnDCa4HNcN5XVVb 6/j5M+kPQwxUAR3cone+QA9q5HcVDynZ7Z08cTusxkLGXVg0c4hQRcDJ+8wvusTmgynu bli5EYVN4+/38/fB+RuuWZac8ftiDJKkVCXc5qatiiJ/rlmJo1KaB8qGT4SEj00lU0dm GIWg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=62MG5B/ncqLFJMCPey88hP/CHS6L6DB9Q0Ol9XSuCU0=; b=V+qp1LJ7sIpXE16c4cb8jUiO3sgXO2gVgU1kOmu/U3gV7Xgk2kLnb8OYZBy5dm0JL+ qMsAyK1tJRqTufnUYLoaEnxZ+sjDDCXARwhBNzkUeJQ/7zWG49hASed1ACfbTJ7aZUsX RDaehCMLFEONkynxmBNdP6FddwJKgMe1JXKZzjruf5VvWvGcqxvqsgfN7dKrWV+Fm6Ec QNSRxilk88lGzEzw2PNufrs15DHC5NdVWA6jmDW6LBT5z3WEBMSHsgmFtBYPwCTj5IYT 6KFm1atw/EZ9DQL2c7avVQAgTsDPLQqush+4OHoQv9+rybpuYFTv3rtsBShQ28g+Ruiv BFkw== X-Gm-Message-State: AOAM531AQ8a/cWnfnPWqzvAD7wHwGgjRkYpW+KY0WfUrJMc7GG29YrBi nZyaX3xlLqn1IOEmDlNiQ2d5Dg== X-Google-Smtp-Source: ABdhPJy/9I03HGLRDPxWYhmODRNbrqIlmbhzU7iLkesDoviBLjKir9yrAu73CgWO7rgAbVaHgne8Jw== X-Received: by 2002:a37:aec5:: with SMTP id x188mr5386628qke.144.1611329074636; Fri, 22 Jan 2021 07:24:34 -0800 (PST) Received: from [192.168.1.45] (cpe-174-109-172-136.nc.res.rr.com. [174.109.172.136]) by smtp.gmail.com with ESMTPSA id j23sm6023312qtr.79.2021.01.22.07.24.33 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 22 Jan 2021 07:24:33 -0800 (PST) Subject: Re: [PATCH v13 26/42] btrfs: save irq flags when looking up an ordered extent To: Naohiro Aota , linux-btrfs@vger.kernel.org, dsterba@suse.com Cc: hare@suse.com, linux-fsdevel@vger.kernel.org, Jens Axboe , Christoph Hellwig , "Darrick J. Wong" , Johannes Thumshirn References: <8537c12ab50510bf029ff6c780a0ce2a850fa603.1611295439.git.naohiro.aota@wdc.com> From: Josef Bacik Message-ID: <8405f0b4-ccf0-5b0d-f71a-31857642b2ae@toxicpanda.com> Date: Fri, 22 Jan 2021 10:24:32 -0500 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:78.0) Gecko/20100101 Thunderbird/78.6.1 MIME-Version: 1.0 In-Reply-To: <8537c12ab50510bf029ff6c780a0ce2a850fa603.1611295439.git.naohiro.aota@wdc.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 1/22/21 1:21 AM, Naohiro Aota wrote: > From: Johannes Thumshirn > > A following patch will add another caller of > btrfs_lookup_ordered_extent() from a bio endio context. > > btrfs_lookup_ordered_extent() uses spin_lock_irq() which unconditionally > disables interrupts. Change this to spin_lock_irqsave() so interrupts > aren't disabled and re-enabled unconditionally. > > Signed-off-by: Johannes Thumshirn Reviewed-by: Josef Bacik Thanks, Josef