From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,UNPARSEABLE_RELAY autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 30AB0C4740C for ; Mon, 9 Sep 2019 14:22:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 0BE72218DE for ; Mon, 9 Sep 2019 14:22:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726756AbfIIOV7 (ORCPT ); Mon, 9 Sep 2019 10:21:59 -0400 Received: from bhuna.collabora.co.uk ([46.235.227.227]:58516 "EHLO bhuna.collabora.co.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726188AbfIIOV7 (ORCPT ); Mon, 9 Sep 2019 10:21:59 -0400 Received: from [127.0.0.1] (localhost [127.0.0.1]) (Authenticated sender: krisman) with ESMTPSA id 4606B28BB4D From: Gabriel Krisman Bertazi To: Colin King Cc: linux-fsdevel@vger.kernel.org, kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] unicode: make array 'token' static const, makes object smaller Organization: Collabora References: <20190906135807.23152-1-colin.king@canonical.com> Date: Mon, 09 Sep 2019 10:21:53 -0400 In-Reply-To: <20190906135807.23152-1-colin.king@canonical.com> (Colin King's message of "Fri, 6 Sep 2019 14:58:07 +0100") Message-ID: <855zm1h7ni.fsf@collabora.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Colin King writes: > From: Colin Ian King > > Don't populate the array 'token' on the stack but instead make it > static const. Makes the object code smaller by 234 bytes. > > Before: > text data bss dec hex filename > 5371 272 0 5643 160b fs/unicode/utf8-core.o > > After: > text data bss dec hex filename > 5041 368 0 5409 1521 fs/unicode/utf8-core.o > > (gcc version 9.2.1, amd64) > > Signed-off-by: Colin Ian King Thanks, I will get this queued up. -- Gabriel Krisman Bertazi