From: Jens Axboe <axboe@kernel.dk>
To: Palash Oswal <hello@oswalpalash.com>,
Pavel Begunkov <asml.silence@gmail.com>,
Alexander Viro <viro@zeniv.linux.org.uk>,
io-uring@vger.kernel.org, linux-fsdevel@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] io_uring: check ctx->sq_data before io_sq_offload_start
Date: Mon, 19 Apr 2021 11:56:20 -0600 [thread overview]
Message-ID: <857554eb-d020-7e45-edd5-0b15bc2d1945@kernel.dk> (raw)
In-Reply-To: <20210419123630.62212-1-hello@oswalpalash.com>
On 4/19/21 6:36 AM, Palash Oswal wrote:
> syzkaller identified KASAN: null-ptr-deref Read in io_uring_create
> bug on the stable 5.11-y tree.
>
> BUG: KASAN: null-ptr-deref in io_sq_offload_start fs/io_uring.c:8254 [inline]
> BUG: KASAN: null-ptr-deref in io_disable_sqo_submit fs/io_uring.c:8999 [inline]
> BUG: KASAN: null-ptr-deref in io_uring_create+0x1275/0x22f0 fs/io_uring.c:9824
> Read of size 8 at addr 0000000000000068 by task syz-executor.0/4350
>
> A simple reproducer for this bug is:
>
> int main(void)
> {
> syscall(__NR_mmap, 0x20000000ul, 0x1000000ul, 7ul, 0x32ul, -1, 0ul);
> intptr_t res = 0;
> pid_t parent = getpid();
> *(uint32_t*)0x20000084 = 0;
> *(uint32_t*)0x20000088 = 0x42;
> *(uint32_t*)0x2000008c = 0;
> *(uint32_t*)0x20000090 = 0;
> *(uint32_t*)0x20000098 = -1;
> *(uint32_t*)0x2000009c = 0;
> *(uint32_t*)0x200000a0 = 0;
> *(uint32_t*)0x200000a4 = 0;
> if (fork() == 0) {
> kill(parent,SIGKILL);
> exit(0);
> }
> res = syscall(__NR_io_uring_setup, 0x7994, 0x20000080ul);
> return 0;
> }
>
> Due to the SIGKILL sent to the process before io_uring_setup
> completes, ctx->sq_data is NULL. Therefore, io_sq_offload_start
> does a null pointer dereferenced read. More details on this bug
> are in [1]. Discussion for this patch happened in [2].
>
> [1] https://oswalpalash.com/exploring-null-ptr-deref-io-uring-submit
> [2] https://lore.kernel.org/io-uring/a08121be-f481-e9f8-b28d-3eb5d4f
> a5b76@gmail.com/
This should be a backport of the 5.12 fix, not a separate patch.
--
Jens Axboe
prev parent reply other threads:[~2021-04-19 17:56 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-19 12:36 [PATCH] io_uring: check ctx->sq_data before io_sq_offload_start Palash Oswal
2021-04-19 17:56 ` Jens Axboe [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=857554eb-d020-7e45-edd5-0b15bc2d1945@kernel.dk \
--to=axboe@kernel.dk \
--cc=asml.silence@gmail.com \
--cc=hello@oswalpalash.com \
--cc=io-uring@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).