* [PATCH][next] io_uring: Fix sizeof() mismatch
@ 2020-10-12 14:03 Colin King
2020-10-12 14:24 ` Jens Axboe
0 siblings, 1 reply; 2+ messages in thread
From: Colin King @ 2020-10-12 14:03 UTC (permalink / raw)
To: Alexander Viro, Jens Axboe, Pavel Begunkov, linux-fsdevel, io-uring
Cc: kernel-janitors, linux-kernel
From: Colin Ian King <colin.king@canonical.com>
An incorrect sizeof() is being used, sizeof(file_data->table) is not
correct, it should be sizeof(*file_data->table).
Addresses-Coverity: ("Sizeof not portable (SIZEOF_MISMATCH)")
Fixes: 5398ae698525 ("io_uring: clean file_data access in files_register")
Signed-off-by: Colin Ian King <colin.king@canonical.com>
---
fs/io_uring.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/fs/io_uring.c b/fs/io_uring.c
index b58169240c77..6b30670fffbd 100644
--- a/fs/io_uring.c
+++ b/fs/io_uring.c
@@ -7306,7 +7306,7 @@ static int io_sqe_files_register(struct io_ring_ctx *ctx, void __user *arg,
spin_lock_init(&file_data->lock);
nr_tables = DIV_ROUND_UP(nr_args, IORING_MAX_FILES_TABLE);
- file_data->table = kcalloc(nr_tables, sizeof(file_data->table),
+ file_data->table = kcalloc(nr_tables, sizeof(*file_data->table),
GFP_KERNEL);
if (!file_data->table)
goto out_free;
--
2.27.0
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH][next] io_uring: Fix sizeof() mismatch
2020-10-12 14:03 [PATCH][next] io_uring: Fix sizeof() mismatch Colin King
@ 2020-10-12 14:24 ` Jens Axboe
0 siblings, 0 replies; 2+ messages in thread
From: Jens Axboe @ 2020-10-12 14:24 UTC (permalink / raw)
To: Colin King, Alexander Viro, Pavel Begunkov, linux-fsdevel, io-uring
Cc: kernel-janitors, linux-kernel
On 10/12/20 8:03 AM, Colin King wrote:
> From: Colin Ian King <colin.king@canonical.com>
>
> An incorrect sizeof() is being used, sizeof(file_data->table) is not
> correct, it should be sizeof(*file_data->table).
Thanks, should be a no-op, which is why KASAN didn't complain in my
testing. I'll queue this up, thanks.
--
Jens Axboe
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2020-10-12 14:24 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2020-10-12 14:03 [PATCH][next] io_uring: Fix sizeof() mismatch Colin King
2020-10-12 14:24 ` Jens Axboe
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).