From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 935E3C433E0 for ; Fri, 22 May 2020 13:39:05 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 7F29820825 for ; Fri, 22 May 2020 13:39:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729868AbgEVNjB (ORCPT ); Fri, 22 May 2020 09:39:01 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:34864 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729406AbgEVNjA (ORCPT ); Fri, 22 May 2020 09:39:00 -0400 Received: from in02.mta.xmission.com ([166.70.13.52]) by out03.mta.xmission.com with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jc7sy-0003j6-TB; Fri, 22 May 2020 07:38:53 -0600 Received: from ip68-227-160-95.om.om.cox.net ([68.227.160.95] helo=x220.xmission.com) by in02.mta.xmission.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.87) (envelope-from ) id 1jc7sx-0000zH-CV; Fri, 22 May 2020 07:38:52 -0600 From: ebiederm@xmission.com (Eric W. Biederman) To: Rob Landley Cc: linux-kernel@vger.kernel.org, Linus Torvalds , Oleg Nesterov , Jann Horn , Kees Cook , Greg Ungerer , Bernd Edlinger , linux-fsdevel@vger.kernel.org, Al Viro , Alexey Dobriyan , Andrew Morton , Casey Schaufler , linux-security-module@vger.kernel.org, James Morris , "Serge E. Hallyn" , Andy Lutomirski References: <87h7wujhmz.fsf@x220.int.ebiederm.org> <87sgga6ze4.fsf@x220.int.ebiederm.org> <87v9l4zyla.fsf_-_@x220.int.ebiederm.org> <877dx822er.fsf_-_@x220.int.ebiederm.org> <87y2poyd91.fsf_-_@x220.int.ebiederm.org> <874ksaioc6.fsf@x220.int.ebiederm.org> <87r1vcd4wo.fsf@x220.int.ebiederm.org> <6ce125fd-4fb1-8c39-a9a9-098391f2016a@landley.net> Date: Fri, 22 May 2020 08:35:06 -0500 In-Reply-To: <6ce125fd-4fb1-8c39-a9a9-098391f2016a@landley.net> (Rob Landley's message of "Thu, 21 May 2020 23:51:20 -0500") Message-ID: <871rnccctx.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-SPF: eid=1jc7sx-0000zH-CV;;;mid=<871rnccctx.fsf@x220.int.ebiederm.org>;;;hst=in02.mta.xmission.com;;;ip=68.227.160.95;;;frm=ebiederm@xmission.com;;;spf=neutral X-XM-AID: U2FsdGVkX1+mSrIOE54/VQp+XUfD3u/JlfcpgUct7Ko= X-SA-Exim-Connect-IP: 68.227.160.95 X-SA-Exim-Mail-From: ebiederm@xmission.com Subject: Re: [PATCH v2 7/8] exec: Generic execfd support X-SA-Exim-Version: 4.2.1 (built Thu, 05 May 2016 13:38:54 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Rob Landley writes: > On 5/21/20 10:28 PM, Eric W. Biederman wrote: >> >> Rob Landley writes: >> >>> On 5/20/20 11:05 AM, Eric W. Biederman wrote: >> >>>> The file descriptor is stored in mm->exe_file. >>>> Probably the most straight forward implementation is to allow >>>> execveat(AT_EXE_FILE, ...). >>> >>> Cool, that works. >>> >>>> You can look at binfmt_misc for how to reopen an open file descriptor. >>> >>> Added to the todo heap. >> >> Yes I don't think it would be a lot of code. >> >> I think you might be better served with clone(CLONE_VM) as it doesn't >> block so you don't need to feed yourself your context over a pipe. > > Except that doesn't fix it. > > Yes I could use threads instead, but the cure is worse than the disease and the > result is your shell background processes are threads rather than independent > processes (is $$ reporting PID or TID, I really don't want to go > there). I was just suggesting clone(CLONE_VM) because it creates a thread in a separate process. Which on nommu sounds like it could be almost exactly what you want. If you need the separate copies of all of your global variables etc, re-exec'ing your self could be the easier way to go. Eric