From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from icp-osb-irony-out9.external.iinet.net.au ([203.59.1.226]:3601 "EHLO icp-osb-irony-out9.external.iinet.net.au" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751671AbcGTHOU (ORCPT ); Wed, 20 Jul 2016 03:14:20 -0400 Subject: Re: [PATCH v3 09/12] binfmt_flat: use clear_user() rather than memset() to clear .bss To: Nicolas Pitre , linux-fsdevel@vger.kernel.org, linux-kernel@vger.kernel.org References: <1468988424-32671-1-git-send-email-nicolas.pitre@linaro.org> <1468988424-32671-10-git-send-email-nicolas.pitre@linaro.org> Cc: Alexander Viro , David Howells From: Greg Ungerer Message-ID: <875c0a70-fb68-9801-9257-0b74f34c784c@linux-m68k.org> Date: Wed, 20 Jul 2016 17:15:15 +1000 MIME-Version: 1.0 In-Reply-To: <1468988424-32671-10-git-send-email-nicolas.pitre@linaro.org> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-fsdevel-owner@vger.kernel.org List-ID: On 20/07/16 14:20, Nicolas Pitre wrote: > This is needed on systems with a MMU. > > Signed-off-by: Nicolas Pitre > Reviewed-by: Greg Ungerer > --- > fs/binfmt_flat.c | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > > diff --git a/fs/binfmt_flat.c b/fs/binfmt_flat.c > index 28fc272d9a..0d89830f76 100644 > --- a/fs/binfmt_flat.c > +++ b/fs/binfmt_flat.c > @@ -798,10 +798,11 @@ static int load_flat_file(struct linux_binprm * bprm, > flush_icache_range(start_code, end_code); > > /* zero the BSS, BRK and stack areas */ > - memset((void*)(datapos + data_len), 0, bss_len + > + if (clear_user((void __user *)(datapos + data_len), bss_len + nit: this adds a trailing white space ^ (Yes, the memset did have this before as well) Regards Greg > (memp + memp_size - stack_len - /* end brk */ > libinfo->lib_list[id].start_brk) + /* start brk */ > - stack_len); > + stack_len)) > + return -EFAULT; > > return 0; > err: >