From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: Hou Tao <houtao1@huawei.com>,
linux-fsdevel@vger.kernel.org, viro@zeniv.linux.org.uk,
jack@suse.cz, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] fat: issue flush after the writeback of FAT
Date: Tue, 09 Apr 2019 14:22:31 +0900 [thread overview]
Message-ID: <87a7gzbvmw.fsf@mail.parknet.co.jp> (raw)
In-Reply-To: <20190409034100.GF1177@magnolia> (Darrick J. Wong's message of "Mon, 8 Apr 2019 20:41:00 -0700")
"Darrick J. Wong" <darrick.wong@oracle.com> writes:
>> + err = __generic_file_fsync(filp, start, end, datasync);
>> + if (err)
>> + return err;
>>
>> - res = generic_file_fsync(filp, start, end, datasync);
>> err = sync_mapping_buffers(MSDOS_SB(inode->i_sb)->fat_inode->i_mapping);
>
> Huh. I would've thought that flushing the FAT would also be required
> at the end of a WB_SYNC_ALL (aka data integrity) writepages call?
In fatfs implement, FAT area is flushed by sync_mapping_buffers(fat_inode).
(FAT buffer is dirtied only by using bh->b_assoc_map to fat_inode)
Thanks.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
next prev parent reply other threads:[~2019-04-09 5:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 3:01 [PATCH] fat: issue flush after the writeback of FAT Hou Tao
2019-04-09 3:41 ` Darrick J. Wong
2019-04-09 5:22 ` OGAWA Hirofumi [this message]
2019-04-09 5:16 ` OGAWA Hirofumi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87a7gzbvmw.fsf@mail.parknet.co.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=darrick.wong@oracle.com \
--cc=houtao1@huawei.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).