From: "Aurélien Aptel" <aaptel@suse.com>
To: NeilBrown <neilb@suse.com>, linux-fsdevel@vger.kernel.org
Subject: Re: Duplicate network filesystems
Date: Fri, 15 Feb 2019 11:18:04 +0100 [thread overview]
Message-ID: <87ef89qrs3.fsf@suse.com> (raw)
In-Reply-To: <87mumxen2m.fsf@notabene.neil.brown.name>
NeilBrown <neilb@suse.com> writes:
>> mount //foo /mnt -o A
>> mount //foo /mnt -o B # different options
>>
>> Since the SB are different it works, fine.
>>
>> But mounting a 3rd time with options A succeeds, where from a user POV I
>> would have expected to fail.
>
> Why?
Because it's already mounted.
>> mount //foo /mnt -o A
>> mount //foo /mnt -o B
>> mount //foo /mnt -o A
>> # ok => what?
>>
>> Shouldn't we check the stack of filesystems mounted at the path instead of
>> just the last one?
>
> Why?
>
> I think that the main reason that -EBUSY is important is that people
> often run "mount -a" and don't expect filesystems that are already
> mounted to be mounted again. The current behaviour achieves that.
A is already mounted and mouting again succeeds. The current behaviour is
different from what you described. This is exactly what I was saying
earlier "from a user POV".
Side-note:
mount from coreutils has some logic to deal with -a and network
filesystems, because there are some issues with the default behaviour. I
can't recall the details about that, would have to look at the code
again.
Cheers,
--
Aurélien Aptel / SUSE Labs Samba Team
GPG: 1839 CB5F 9F5B FB9B AA97 8C99 03C8 A49B 521B D5D3
SUSE Linux GmbH, Maxfeldstraße 5, 90409 Nürnberg, Germany
GF: Felix Imendörffer, Jane Smithard, Graham Norton, HRB 21284 (AG Nürnberg)
prev parent reply other threads:[~2019-02-15 10:18 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 17:58 Duplicate network filesystems Aurélien Aptel
2019-02-15 3:40 ` NeilBrown
2019-02-15 10:18 ` Aurélien Aptel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87ef89qrs3.fsf@suse.com \
--to=aaptel@suse.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=neilb@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).