From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.parknet.co.jp ([210.171.160.6]:40848 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727333AbeJAOuy (ORCPT ); Mon, 1 Oct 2018 10:50:54 -0400 From: OGAWA Hirofumi To: Andrew Morton Cc: Frank Sorenson , linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V5 0/4] fat: timestamp updates References: Date: Mon, 01 Oct 2018 17:14:20 +0900 In-Reply-To: (Frank Sorenson's message of "Sun, 30 Sep 2018 22:33:49 -0500") Message-ID: <87muryhyn7.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Frank Sorenson writes: > fat/msdos timestamps are stored on-disk with several different > granularities, some of them lower resolution than timespec64_trunc() > can provide. In addition, they are only truncated as they are > written to disk, so the timestamps in-memory for new or modified > files/directories may be different from the same timestamps after > a remount, as the now-truncated times are re-read from the on-disk > format. > > These patches allow finer granularity for the timestamps where > possible and add fat-specific ->update_time inode operation and > fat_truncate_time functions to truncate each timestamp correctly, > giving consistent times across remounts. Whole patches needs to apply at once, so IMO this is better to be one patch though. Looks good to me. Acked-by: OGAWA Hirofumi Thanks. -- OGAWA Hirofumi