From: Marko Rauhamaa <marko.rauhamaa@f-secure.com>
To: Jan Kara <jack@suse.cz>
Cc: Amir Goldstein <amir73il@gmail.com>, <nixiaoming@huawei.com>,
<linux-fsdevel@vger.kernel.org>, <linux-api@vger.kernel.org>
Subject: Re: [PATCH] fanotify: self describing event metadata
Date: Tue, 9 Oct 2018 10:29:55 +0300 [thread overview]
Message-ID: <87o9c3d1cc.fsf@drapion.f-secure.com> (raw)
In-Reply-To: <20181008115440.GB21682@quack2.suse.cz> (Jan Kara's message of "Mon, 8 Oct 2018 13:54:40 +0200")
Jan Kara <jack@suse.cz>:
> That makes some sense but I'd really like to see how you apply this to
> other things because e.g. with PID vs TGID I don't really see the need
> for any flags. It might be interesting to have PID vs TGID flag there
> for consistency once we really start to send them for other things but
> I don't see a need to rush it now. Plus we are at rc7 already so we
> are out of time for changes going to the coming merge window.
A general side note: the PID is often useless as the process can die
before the fa-notification reaches the handler. I wish there were a
CLOSE_PERM event that held the closing process in existence (as a zombie
if nothing else) until the event has been processed.
Marko
prev parent reply other threads:[~2018-10-09 15:06 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-08 10:12 [PATCH] fanotify: self describing event metadata Amir Goldstein
2018-10-08 11:54 ` Jan Kara
2018-10-08 15:40 ` Amir Goldstein
2018-10-09 7:29 ` Marko Rauhamaa [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87o9c3d1cc.fsf@drapion.f-secure.com \
--to=marko.rauhamaa@f-secure.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-api@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=nixiaoming@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).