From: "Aneesh Kumar K.V" <aneesh.kumar@linux.ibm.com>
To: Jan Kara <jack@suse.cz>
Cc: Jan Kara <jack@suse.cz>, Chandan Rajendra <chandan@linux.ibm.com>,
mpe@ellerman.id.au, Dan Williams <dan.j.williams@intel.com>,
linux-fsdevel@vger.kernel.org
Subject: Re: write fault on dax mapping and usage of set_pte_at.
Date: Thu, 21 Feb 2019 21:37:27 +0530 [thread overview]
Message-ID: <87sgwh86rk.fsf@linux.ibm.com> (raw)
In-Reply-To: <20190221151513.GB23071@quack2.suse.cz>
Jan Kara <jack@suse.cz> writes:
> On Thu 21-02-19 19:11:14, Aneesh Kumar K.V wrote:
>> On 2/21/19 5:42 PM, Jan Kara wrote:
>> > Hi Aneesh,
>> >
>> > On Thu 21-02-19 12:52:39, Aneesh Kumar K.V wrote:
>
>> Do pfn_mkwrite callback need to insert the pfn details for a RO->RW fault
>> type? Can't we skip that pfn insert and let finish_mkwrite_fault handle that
>> pte update?
>
> Yes, pfn_mkwrite() must fully update the PTE as the PTE update must happen
> under a lock that is private to DAX code. Using ptep_set_access_flags()
> in iomap code isn't going to be simple either. I have to think whether /
> how that is possible.
Can we use ptep_clear_flush followed by set_pte_at()?
-aneesh
next prev parent reply other threads:[~2019-02-21 16:07 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <871s41a9mo.fsf@linux.ibm.com>
2019-02-21 12:12 ` write fault on dax mapping and usage of set_pte_at Jan Kara
2019-02-21 13:41 ` Aneesh Kumar K.V
2019-02-21 13:47 ` Aneesh Kumar K.V
2019-02-21 15:15 ` Jan Kara
2019-02-21 15:57 ` Aneesh Kumar K.V
2019-02-21 16:07 ` Aneesh Kumar K.V [this message]
2019-03-01 14:49 ` Jan Kara
2019-03-02 15:23 ` Chandan Rajendra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87sgwh86rk.fsf@linux.ibm.com \
--to=aneesh.kumar@linux.ibm.com \
--cc=chandan@linux.ibm.com \
--cc=dan.j.williams@intel.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=mpe@ellerman.id.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).