From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail.parknet.co.jp ([210.171.160.6]:40162 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729183AbeI1Qyb (ORCPT ); Fri, 28 Sep 2018 12:54:31 -0400 From: OGAWA Hirofumi To: Frank Sorenson Cc: linux-fsdevel@vger.kernel.org Subject: Re: [PATCH V2 2/4] fat: add functions to update and truncate timestamps appropriately References: <20180926224335.5919-1-sorenson@redhat.com> <20180926224335.5919-3-sorenson@redhat.com> Date: Fri, 28 Sep 2018 19:31:21 +0900 In-Reply-To: <20180926224335.5919-3-sorenson@redhat.com> (Frank Sorenson's message of "Wed, 26 Sep 2018 17:43:33 -0500") Message-ID: <87wor5eww6.fsf@mail.parknet.co.jp> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org List-ID: Frank Sorenson writes: > + if (inode->i_ino == MSDOS_ROOT_INO) > + return 0; > + if (flags & S_MTIME) > + inode->i_mtime = (struct timespec64){ now->tv_sec & ~1, 0 }; > + inode->i_mtime = fat_timespec64_trunc_2secs(*now); Looks like the patch is broken. Sent wrong patch? -- OGAWA Hirofumi