From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-4.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A1617C072B1 for ; Tue, 28 May 2019 03:22:26 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8138820675 for ; Tue, 28 May 2019 03:22:26 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728074AbfE1DWW (ORCPT ); Mon, 27 May 2019 23:22:22 -0400 Received: from ozlabs.org ([203.11.71.1]:42241 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728012AbfE1DWW (ORCPT ); Mon, 27 May 2019 23:22:22 -0400 Received: from authenticated.ozlabs.org (localhost [127.0.0.1]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange ECDHE (P-256) server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by mail.ozlabs.org (Postfix) with ESMTPSA id 45CfKQ6Xj1z9s5c; Tue, 28 May 2019 13:22:17 +1000 (AEST) From: Michael Ellerman To: Christian Brauner , viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, torvalds@linux-foundation.org, fweimer@redhat.com Cc: jannh@google.com, oleg@redhat.com, tglx@linutronix.de, arnd@arndb.de, shuah@kernel.org, dhowells@redhat.com, tkjos@android.com, ldv@altlinux.org, miklos@szeredi.hu, Christian Brauner , linux-api@vger.kernel.org, linux-kselftest@vger.kernel.org Subject: Re: [PATCH v3 3/3] tests: add close_range() tests In-Reply-To: <20190524111047.6892-4-christian@brauner.io> References: <20190524111047.6892-1-christian@brauner.io> <20190524111047.6892-4-christian@brauner.io> Date: Tue, 28 May 2019 13:22:10 +1000 Message-ID: <87zhn7p8kd.fsf@concordia.ellerman.id.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org Christian Brauner writes: > This adds basic tests for the new close_range() syscall. > - test that no invalid flags can be passed > - test that a range of file descriptors is correctly closed > - test that a range of file descriptors is correctly closed if there there > are already closed file descriptors in the range > - test that max_fd is correctly capped to the current fdtable maximum > > Signed-off-by: Christian Brauner > Cc: Arnd Bergmann > Cc: Jann Horn > Cc: David Howells > Cc: Dmitry V. Levin > Cc: Oleg Nesterov > Cc: Linus Torvalds > Cc: Florian Weimer > Cc: Shuah Khan > Cc: linux-api@vger.kernel.org > Cc: linux-kselftest@vger.kernel.org > --- > v1: unchanged > v2: > - Christian Brauner : > - verify that close_range() correctly closes a single file descriptor > v3: > - Christian Brauner : > - add missing Cc for Shuah > - add missing Cc for linux-kselftest Sorry I replied to v2, but I think my comments still apply: https://lore.kernel.org/lkml/8736kzqpdm.fsf@concordia.ellerman.id.au/ cheers