From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rob Browning Subject: Re: Argument type for FS_IOC_GETFLAGS/FS_IOC_SETFLAGS ioctls Date: Thu, 19 Dec 2013 12:20:32 -0600 Message-ID: <87zjnw1z4f.fsf@trouble.defaultvalue.org> References: <20131126200559.GH20559@hall.aurel32.net> <20131127010141.GA10273@birch.djwong.org> Mime-Version: 1.0 Content-Type: text/plain Cc: Aurelien Jarno , Alexander Viro , linux-fsdevel@vger.kernel.org, Robert Edmonds To: "Darrick J. Wong" Return-path: Received: from defaultvalue.org ([70.85.129.156]:45841 "EHLO defaultvalue.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753757Ab3LSSUd (ORCPT ); Thu, 19 Dec 2013 13:20:33 -0500 In-Reply-To: <20131127010141.GA10273@birch.djwong.org> (Darrick J. Wong's message of "Tue, 26 Nov 2013 17:01:41 -0800") Sender: linux-fsdevel-owner@vger.kernel.org List-ID: "Darrick J. Wong" writes: > On Tue, Nov 26, 2013 at 09:05:59PM +0100, Aurelien Jarno wrote: > It also causes problems with FUSE, because the kernel fuse driver expects to be > able to transfer a ulong to and from userspace, but chattr & friends only > allocate an int on the stack, so stack mashing seems to happen. > > I complained to tytso about it on linux-ext4 a while ago, he suggested > special-casing fuse... I haven't gotten around to doing that. So if we didn't make a mistake, we changed bup to use int as suggested by this thread, and now it appears to crash at least sometimes when FUSE is involved: https://groups.google.com/forum/#!topic/bup-list/QxcHthbLHjw Is the problem (you mentioned above) that FUSE always expects a long, and if so, is there a way to tell that we're talking to FUSE? Thanks -- Rob Browning rlb @defaultvalue.org and @debian.org GPG as of 2011-07-10 E6A9 DA3C C9FD 1FF8 C676 D2C4 C0F0 39E9 ED1B 597A GPG as of 2002-11-03 14DD 432F AE39 534D B592 F9A0 25C8 D377 8C7E 73A4