From: Josef Bacik <josef@toxicpanda.com>
To: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Al Viro <viro@zeniv.linux.org.uk>,
Andrew Morton <akpm@linux-foundation.org>,
linux-fsdevel <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH] pipe: fix hang when racing with a wakeup
Date: Thu, 1 Oct 2020 17:08:25 -0400 [thread overview]
Message-ID: <890b194d-8ed5-5434-3336-ffe8e287bde5@toxicpanda.com> (raw)
In-Reply-To: <CAHk-=whwZxj0WdGk2ryax574ut1xPq-=12DcFxZgq9rmCBdDbg@mail.gmail.com>
On 10/1/20 2:38 PM, Linus Torvalds wrote:
> On Thu, Oct 1, 2020 at 10:41 AM Josef Bacik <josef@toxicpanda.com> wrote:
>>
>> Obviously not ideal, but I figured the simpler fix was better for stable, and
>> then we could work out something better.
>
> I think the attached is the proper fix, and it's not really any more
> complicated.
>
> The patch is bigger, but it's pretty obvious: get rid of the
> non-specific "pipe_wait()", and replace them with specific versions
> that wait for a particular thing.
>
> NOTE! Entirely untested. It seems to build fine for me, and it _looks_
> obvious, but I haven't actually rebooted to see if it works at all. I
> don't think I have any real splice-heavy test cases.
>
> Mind trying this out on the load that showed problems?
>
It's been running for an hour without hanging, you can add
Reviewed-and-tested-by: Josef Bacik <josef@toxicpanda.com>
Thanks!
Josef
prev parent reply other threads:[~2020-10-01 21:08 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-01 15:58 [PATCH] pipe: fix hang when racing with a wakeup Josef Bacik
2020-10-01 17:28 ` Linus Torvalds
2020-10-01 17:41 ` Josef Bacik
2020-10-01 18:38 ` Linus Torvalds
2020-10-01 19:52 ` Josef Bacik
2020-10-01 21:08 ` Josef Bacik [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=890b194d-8ed5-5434-3336-ffe8e287bde5@toxicpanda.com \
--to=josef@toxicpanda.com \
--cc=akpm@linux-foundation.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=torvalds@linux-foundation.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).