From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <SRS0=4V35=SM=vger.kernel.org=linux-fsdevel-owner@kernel.org>
X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on
	aws-us-west-2-korg-lkml-1.web.codeaurora.org
X-Spam-Level: 
X-Spam-Status: No, score=-1.0 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS,
	MAILING_LIST_MULTI,SPF_PASS autolearn=unavailable autolearn_force=no
	version=3.4.0
Received: from mail.kernel.org (mail.kernel.org [198.145.29.99])
	by smtp.lore.kernel.org (Postfix) with ESMTP id B720BC282CE
	for <linux-fsdevel@archiver.kernel.org>; Wed, 10 Apr 2019 10:02:07 +0000 (UTC)
Received: from vger.kernel.org (vger.kernel.org [209.132.180.67])
	by mail.kernel.org (Postfix) with ESMTP id 8580820850
	for <linux-fsdevel@archiver.kernel.org>; Wed, 10 Apr 2019 10:02:07 +0000 (UTC)
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1728986AbfDJKB4 (ORCPT
        <rfc822;linux-fsdevel@archiver.kernel.org>);
        Wed, 10 Apr 2019 06:01:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:50254 "EHLO mx1.redhat.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1726494AbfDJKB4 (ORCPT <rfc822;linux-fsdevel@vger.kernel.org>);
        Wed, 10 Apr 2019 06:01:56 -0400
Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15])
        (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits))
        (No client certificate requested)
        by mx1.redhat.com (Postfix) with ESMTPS id F0ECF2D808;
        Wed, 10 Apr 2019 10:01:55 +0000 (UTC)
Received: from warthog.procyon.org.uk (ovpn-121-98.rdu2.redhat.com [10.10.121.98])
        by smtp.corp.redhat.com (Postfix) with ESMTP id 7089B5D719;
        Wed, 10 Apr 2019 10:01:53 +0000 (UTC)
Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley
        Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United
        Kingdom.
        Registered in England and Wales under Company Registration No. 3798903
From:   David Howells <dhowells@redhat.com>
In-Reply-To: <20190328144507.GV32590@kadam>
References: <20190328144507.GV32590@kadam> <155372999953.7602.13784796495137723805.stgit@warthog.procyon.org.uk> <155373020049.7602.8355937001441630312.stgit@warthog.procyon.org.uk>
To:     Dan Carpenter <dan.carpenter@oracle.com>
Cc:     dhowells@redhat.com, viro@zeniv.linux.org.uk,
        devel@driverdev.osuosl.org, Todd Kjos <tkjos@android.com>,
        Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
        linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
        Arve =?iso-8859-1?B?SGr4bm5lduVn?= <arve@android.com>,
        Joel Fernandes <joel@joelfernandes.org>,
        Martijn Coenen <maco@android.com>,
        Christian Brauner <christian@brauner.io>
Subject: Re: [RFC PATCH 22/68] vfs: Convert binderfs to use the new mount API
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-ID: <890.1554890512.1@warthog.procyon.org.uk>
Date:   Wed, 10 Apr 2019 11:01:52 +0100
Message-ID: <891.1554890512@warthog.procyon.org.uk>
X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15
X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Wed, 10 Apr 2019 10:01:56 +0000 (UTC)
Sender: linux-fsdevel-owner@vger.kernel.org
Precedence: bulk
List-ID: <linux-fsdevel.vger.kernel.org>
X-Mailing-List: linux-fsdevel@vger.kernel.org

Dan Carpenter <dan.carpenter@oracle.com> wrote:

> > +		struct ipc_namespace *ipc_ns = fc->s_fs_info;
> > +		put_ipc_ns(ipc_ns);
> 
> I feel like put_ipc_ns(info->ipc_ns) would be more readable.

Not so much more readable as more correct.

David