From: Eric Sandeen <sandeen@redhat.com>
To: fsdevel <linux-fsdevel@vger.kernel.org>
Cc: Jan Kara <jack@suse.cz>, Josef Bacik <jbacik@fb.com>
Subject: Re: [PATCH V2] fs: avoid softlockups in s_inodes iterators
Date: Mon, 14 Oct 2019 16:36:58 -0500 [thread overview]
Message-ID: <8af0e23f-b7a4-d046-3ebd-fb30c3f18700@redhat.com> (raw)
In-Reply-To: <a26fae1d-a741-6eb1-b460-968a3b97e238@redhat.com>
On 10/14/19 4:30 PM, Eric Sandeen wrote:
> Anything that walks all inodes on sb->s_inodes list without rescheduling
> risks softlockups.
>
> Previous efforts were made in 2 functions, see:
>
> c27d82f fs/drop_caches.c: avoid softlockups in drop_pagecache_sb()
> ac05fbb inode: don't softlockup when evicting inodes
>
> but there hasn't been an audit of all walkers, so do that now. This
> also consistently moves the cond_resched() calls to the bottom of each
> loop in cases where it already exists.
>
> One loop remains: remove_dquot_ref(), because I'm not quite sure how
> to deal with that one w/o taking the i_lock.
>
> Signed-off-by: Eric Sandeen <sandeen@redhat.com>
Whoops, cc: Jan & Josef as on original, sorry.
next prev parent reply other threads:[~2019-10-14 21:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-14 21:30 [PATCH V2] fs: avoid softlockups in s_inodes iterators Eric Sandeen
2019-10-14 21:36 ` Eric Sandeen [this message]
2019-10-15 7:37 ` Jan Kara
2019-10-16 2:36 ` Eric Sandeen
2019-10-16 9:42 ` Jan Kara
2019-10-16 13:23 ` Eric Sandeen
2019-10-16 13:49 ` Jan Kara
2019-10-16 14:39 ` Eric Sandeen
2019-10-16 15:26 ` Eric Sandeen
2019-10-16 15:35 ` Jan Kara
2019-10-16 17:11 ` [PATCH 2/1] fs: call fsnotify_sb_delete after evict_inodes Eric Sandeen
2019-10-17 8:39 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8af0e23f-b7a4-d046-3ebd-fb30c3f18700@redhat.com \
--to=sandeen@redhat.com \
--cc=jack@suse.cz \
--cc=jbacik@fb.com \
--cc=linux-fsdevel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).