archive mirror
 help / color / mirror / Atom feed
From: Andrew Price <>
To: David Howells <>
Subject: Re: [PATCH 1/2] gfs2: Convert gfs2 to fs_context
Date: Tue, 19 Mar 2019 13:38:54 +0000	[thread overview]
Message-ID: <> (raw)
In-Reply-To: <>

On 18/03/2019 23:01, David Howells wrote:
> Andrew Price <> wrote:
>>> Umm...  What about the fs_context struct?  Why can't that be used to
>>> propagate the bdev pointer?  That's kind of what it's for...
>> It would be useful to have the block device pointer in the fs_context since so
>> many of the filesystems use them and it makes for an obvious API migration.
> That may be so.  I've argued also that we should put a net-namespace pointer
> in there, but Al disagreed.
> However, I think most bdev-based filesystems use mount_bdev() which gfs2 does
> not.
>>> It looks like you should be able to stash the bdev pointer in the gfs2_args
>>> struct.
>> Sure, but since the new API is young I figured I'd hold off until we had this
>> conversation because adding it to the fs_context might be agreeable :)
> Note that I have patches to kill of sget_userns() and sget() will hopefully
> soon follow.  Have a look at:

That's fair enough. I'll update the patch to put the bdev in the 
gfs2_args struct and use sget_fc().


      reply	other threads:[~2019-03-19 13:38 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-03-17 17:40 [PATCH 0/2] gfs2: Switch to the new mount API Andrew Price
2019-03-17 17:40 ` [PATCH 1/2] gfs2: Convert gfs2 to fs_context Andrew Price
2019-03-17 17:40 ` [PATCH 2/2] gfs2: Convert gfs2meta " Andrew Price
2019-03-18  9:56 ` [Cluster-devel] [PATCH 0/2] gfs2: Switch to the new mount API Steven Whitehouse
2019-03-18 13:18 ` [PATCH 1/2] gfs2: Convert gfs2 to fs_context David Howells
2019-03-18 13:51   ` Andrew Price
2019-03-18 23:01   ` David Howells
2019-03-19 13:38     ` Andrew Price [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \ \ \ \ \ \

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).