From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.6 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2BB60C43460 for ; Tue, 18 May 2021 10:06:55 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 10CE661184 for ; Tue, 18 May 2021 10:06:55 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1348342AbhERKIL (ORCPT ); Tue, 18 May 2021 06:08:11 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:30732 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1348341AbhERKIG (ORCPT ); Tue, 18 May 2021 06:08:06 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1621332408; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=dFkmeu2athwSt2LK0RUUi/E/grHFe/dKRRuvCpK8qJo=; b=Jz46/iEL2CI5eOOR0VslPi4IvMIEHryICTdHTZTi4DLK7snBGh+9W6VKWvWYRjcDIRYJ1R PZnrKD9US/nVolN7oIjNK7k/COF0R/JuAWBfyGNiJNkOnwFlsPnm8/bZIc+VDjIbUeBQMu yhx2ghzn0ryv0mJGm+AnWGsMfHDq5pw= Received: from mail-wr1-f72.google.com (mail-wr1-f72.google.com [209.85.221.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-22-E-z_O64YPhigONpVpZLulQ-1; Tue, 18 May 2021 06:06:46 -0400 X-MC-Unique: E-z_O64YPhigONpVpZLulQ-1 Received: by mail-wr1-f72.google.com with SMTP id p11-20020adfc38b0000b0290111f48b8adfso1878864wrf.7 for ; Tue, 18 May 2021 03:06:46 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:organization :message-id:date:user-agent:mime-version:in-reply-to :content-language:content-transfer-encoding; bh=dFkmeu2athwSt2LK0RUUi/E/grHFe/dKRRuvCpK8qJo=; b=RvBKx6iuT8/RxIhZd2MVrBXO1KLD4WzkRarKVWbTGwnTTlsejCu4kzs+9E9lEbEL1x TmHMRUri2s/TfDn2O7ZLJpNGEeWqi4HwAL3dbg6llC2dngAQ8csLYzvHrAX8CnViiTOI Myg3ipNA5zDpQh9Ccx76wrqIBpAzhTPqspSwvbARcaDMPQFDkUMikmz9cNs9MvPwsmT2 Yoak2vC2cvm1VU0z1q/9jWwvvJv00ayVw50maU6GTWmLFVRRmKSt1JY1DhrMmBgwUv2n 4JhGqTd7600vLQxryHUhv1iNHPNfEBjKNGK/nwizZWWktAxN9D4oZIDTjj+up3U61sc8 1WMg== X-Gm-Message-State: AOAM5333lBVMPy21FK1FA1aRiW7xEIkYjMbdcknnfacATUOE6E57T8na QhHANCm+/Jd9N0oC4rBuVEPAK80JINt/2vGJKtxmd7kGzZf+53tK4cw0Bsd/wiwq2so/fxF5i7a jnw1pG2FYXRQZG8slxkuHp080uQ== X-Received: by 2002:a05:6000:1ac5:: with SMTP id i5mr5879846wry.6.1621332405357; Tue, 18 May 2021 03:06:45 -0700 (PDT) X-Google-Smtp-Source: ABdhPJwiVxI2VqHM3UC3HkCv7YVP9ChZhf/paSvmhTbK/1R/b2aClM7EAkaKYj9OwIH5AzvG3tEX6Q== X-Received: by 2002:a05:6000:1ac5:: with SMTP id i5mr5879787wry.6.1621332405164; Tue, 18 May 2021 03:06:45 -0700 (PDT) Received: from [192.168.3.132] (p5b0c64fd.dip0.t-ipconnect.de. [91.12.100.253]) by smtp.gmail.com with ESMTPSA id f14sm8395872wry.40.2021.05.18.03.06.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 18 May 2021 03:06:44 -0700 (PDT) Subject: Re: [PATCH v19 5/8] mm: introduce memfd_secret system call to create "secret" memory areas To: Michal Hocko , Mike Rapoport Cc: Andrew Morton , Alexander Viro , Andy Lutomirski , Arnd Bergmann , Borislav Petkov , Catalin Marinas , Christopher Lameter , Dan Williams , Dave Hansen , Elena Reshetova , "H. Peter Anvin" , Hagen Paul Pfeifer , Ingo Molnar , James Bottomley , Kees Cook , "Kirill A. Shutemov" , Matthew Wilcox , Matthew Garrett , Mark Rutland , Mike Rapoport , Michael Kerrisk , Palmer Dabbelt , Palmer Dabbelt , Paul Walmsley , Peter Zijlstra , "Rafael J. Wysocki" , Rick Edgecombe , Roman Gushchin , Shakeel Butt , Shuah Khan , Thomas Gleixner , Tycho Andersen , Will Deacon , Yury Norov , linux-api@vger.kernel.org, linux-arch@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-nvdimm@lists.01.org, linux-riscv@lists.infradead.org, x86@kernel.org References: <20210513184734.29317-1-rppt@kernel.org> <20210513184734.29317-6-rppt@kernel.org> From: David Hildenbrand Organization: Red Hat Message-ID: <8e114f09-60e4-2343-1c42-1beaf540c150@redhat.com> Date: Tue, 18 May 2021 12:06:42 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.10.1 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org On 18.05.21 11:59, Michal Hocko wrote: > On Sun 16-05-21 10:29:24, Mike Rapoport wrote: >> On Fri, May 14, 2021 at 11:25:43AM +0200, David Hildenbrand wrote: > [...] >>>> + if (!page) >>>> + return VM_FAULT_OOM; >>>> + >>>> + err = set_direct_map_invalid_noflush(page, 1); >>>> + if (err) { >>>> + put_page(page); >>>> + return vmf_error(err); >>> >>> Would we want to translate that to a proper VM_FAULT_..., which would most >>> probably be VM_FAULT_OOM when we fail to allocate a pagetable? >> >> That's what vmf_error does, it translates -ESOMETHING to VM_FAULT_XYZ. > > I haven't read through the rest but this has just caught my attention. > Is it really reasonable to trigger the oom killer when you cannot > invalidate the direct mapping. From a quick look at the code it is quite > unlikely to se ENOMEM from that path (it allocates small pages) but this > can become quite sublte over time. Shouldn't this simply SIGBUS if it > cannot manipulate the direct mapping regardless of the underlying reason > for that? > OTOH, it means our kernel zones are depleted, so we'd better reclaim somehow ... -- Thanks, David / dhildenb