linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: David Howells <dhowells@redhat.com>
To: unlisted-recipients:; (no To-header on input)
Cc: dhowells@redhat.com, Andrei Vagin <avagin@openvz.org>,
	linux-fsdevel@vger.kernel.org, Andrei Vagin <avagin@gmail.com>,
	Eric Biederman <ebiederm@xmission.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>
Subject: Re: [PATCH dhowells/mount-api] proc: set a proper user namespace for fs_context
Date: Tue, 21 Aug 2018 08:39:22 +0100	[thread overview]
Message-ID: <922.1534837162@warthog.procyon.org.uk> (raw)
In-Reply-To: <561.1534836806@warthog.procyon.org.uk>

David Howells <dhowells@redhat.com> wrote:

> > A user namespace should be taken from a pidns for which a procfs is created.
> 
> That would seem wrong.  Shouldn't the superblock user_ns be from the mounter?

Ah, no.  The change is correct.  What the patch description doesn't mention is
that this is when a new pid namespace is setting up its own proc filesystem.

I'll change the subject and patch body to:

    proc: Set correct userns for new proc super created by a new pid_namespace

    Fix the setting up a new proc superblock for a new pid_namespace such that
    the user_ns for that proc superblock needs to be taken from the new
    pid_namespace and not the active process.

which I think describes it better.

David

      parent reply	other threads:[~2018-08-21 10:58 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-16  7:34 [PATCH dhowells/mount-api] proc: set a proper user namespace for fs_context Andrei Vagin
2018-08-16 22:16 ` Andrei Vagin
2018-08-21  7:33 ` David Howells
2018-08-21  7:39 ` David Howells [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=922.1534837162@warthog.procyon.org.uk \
    --to=dhowells@redhat.com \
    --cc=avagin@gmail.com \
    --cc=avagin@openvz.org \
    --cc=ebiederm@xmission.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).