linux-fsdevel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Damien Le Moal <Damien.LeMoal@wdc.com>
To: "Luis R. Rodriguez" <mcgrof@kernel.org>
Cc: "hare@suse.de" <hare@suse.de>,
	"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>,
	"linux-block@vger.kernel.org" <linux-block@vger.kernel.org>
Subject: Re: [PATCH dm-zoned-tools 2/2] README: fix example script
Date: Mon, 30 Apr 2018 20:36:09 +0000	[thread overview]
Message-ID: <9d60b721-6ca4-62cb-d801-a2fe901f4c72@wdc.com> (raw)
In-Reply-To: <20180430194520.9065-2-mcgrof@kernel.org>

On 2018/04/30 12:45, Luis R. Rodriguez wrote:
> The target type should be "zoned", not "dm-zoned".
> 
> Signed-off-by: Luis R. Rodriguez <mcgrof@kernel.org>
> ---
>  README | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> The README does note explain if one should use dmzadm to format a drive
> if using dm zone or only if one is to use a filesystem which supports
> zones, such as f2fs. Or if we should *always* use dmzadm format regardless
> of the circumstance.

dmzadm is only for dm-zoned device mapper. If the file system natively support
zoned block devices, it is the FS problem to format the drive accordingly to
ZBC/ZAC constraints. And for these files systems, dm-zoned is useless.

> Could this be clarfied? What are the downsides to not using dmzadm
> format on a drive and say a user just going straight to use the dm zone
> and then mkfs on top of it?

OK. I will look into it and clarify.

> 
> diff --git a/README b/README
> index 7762694..9aea28e 100644
> --- a/README
> +++ b/README
> @@ -184,7 +184,7 @@ options="$@"
>  
>  modprobe dm-zoned
>  
> -echo "0 `blockdev --getsize ${dev}` dm-zoned ${dev} ${options}" | \
> +echo "0 `blockdev --getsize ${dev}` zoned ${dev} ${options}" | \
>  dmsetup create zoned-`basename ${dev}`
>  ]]

Yes, indeed...

Reviewed-by: Damien Le Moal <damien.lemoal@wdc.com>

-- 
Damien Le Moal
Western Digital Research

  reply	other threads:[~2018-04-30 20:36 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-30 19:45 [PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed Luis R. Rodriguez
2018-04-30 19:45 ` [PATCH dm-zoned-tools 2/2] README: fix example script Luis R. Rodriguez
2018-04-30 20:36   ` Damien Le Moal [this message]
2018-04-30 22:04     ` Luis R. Rodriguez
2018-04-30 20:32 ` [PATCH dm-zoned-tools 1/2] README: fix small typo host-manmaged --> host-managed Damien Le Moal

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=9d60b721-6ca4-62cb-d801-a2fe901f4c72@wdc.com \
    --to=damien.lemoal@wdc.com \
    --cc=hare@suse.de \
    --cc=linux-block@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=mcgrof@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).