From: Boaz Harrosh <boaz@plexistor.com>
To: Jan Kara <jack@suse.cz>, linux-fsdevel@vger.kernel.org
Cc: linux-mm@kvack.org, linux-xfs@vger.kernel.org,
Amir Goldstein <amir73il@gmail.com>,
Boaz Harrosh <boaz@plexistor.com>,
stable@vger.kernel.org
Subject: Re: [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise()
Date: Tue, 23 Jul 2019 06:08:37 +0300 [thread overview]
Message-ID: <9da4596e-7de2-9ba1-0fc0-62bf83c39488@plexistor.com> (raw)
In-Reply-To: <20190711140012.1671-2-jack@suse.cz>
On 11/07/2019 17:00, Jan Kara wrote:
> Currently handling of MADV_WILLNEED hint calls directly into readahead
> code. Handle it by calling vfs_fadvise() instead so that filesystem can
> use its ->fadvise() callback to acquire necessary locks or otherwise
> prepare for the request.
>
> Suggested-by: Amir Goldstein <amir73il@gmail.com>
> CC: stable@vger.kernel.org # Needed by "xfs: Fix stale data exposure
> when readahead races with hole punch"
> Signed-off-by: Jan Kara <jack@suse.cz>
I had a similar patch for my needs. But did not drop the mmap_sem when calling into
the FS. This one is much better.
Reviewed-by: Boaz Harrosh <boazh@netapp.com>
I tested this patch, Works perfect for my needs.
Thank you for this patch
Boaz
> ---
> mm/madvise.c | 22 ++++++++++++++++------
> 1 file changed, 16 insertions(+), 6 deletions(-)
>
> diff --git a/mm/madvise.c b/mm/madvise.c
> index 628022e674a7..ae56d0ef337d 100644
> --- a/mm/madvise.c
> +++ b/mm/madvise.c
> @@ -14,6 +14,7 @@
> #include <linux/userfaultfd_k.h>
> #include <linux/hugetlb.h>
> #include <linux/falloc.h>
> +#include <linux/fadvise.h>
> #include <linux/sched.h>
> #include <linux/ksm.h>
> #include <linux/fs.h>
> @@ -275,6 +276,7 @@ static long madvise_willneed(struct vm_area_struct *vma,
> unsigned long start, unsigned long end)
> {
> struct file *file = vma->vm_file;
> + loff_t offset;
>
> *prev = vma;
> #ifdef CONFIG_SWAP
> @@ -298,12 +300,20 @@ static long madvise_willneed(struct vm_area_struct *vma,
> return 0;
> }
>
> - start = ((start - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
> - if (end > vma->vm_end)
> - end = vma->vm_end;
> - end = ((end - vma->vm_start) >> PAGE_SHIFT) + vma->vm_pgoff;
> -
> - force_page_cache_readahead(file->f_mapping, file, start, end - start);
> + /*
> + * Filesystem's fadvise may need to take various locks. We need to
> + * explicitly grab a reference because the vma (and hence the
> + * vma's reference to the file) can go away as soon as we drop
> + * mmap_sem.
> + */
> + *prev = NULL; /* tell sys_madvise we drop mmap_sem */
> + get_file(file);
> + up_read(¤t->mm->mmap_sem);
> + offset = (loff_t)(start - vma->vm_start)
> + + ((loff_t)vma->vm_pgoff << PAGE_SHIFT);
> + vfs_fadvise(file, offset, end - start, POSIX_FADV_WILLNEED);
> + fput(file);
> + down_read(¤t->mm->mmap_sem);
> return 0;
> }
>
>
next prev parent reply other threads:[~2019-07-23 3:09 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-11 14:00 [PATCH 0/3] xfs: Fix races between readahead and hole punching Jan Kara
2019-07-11 14:00 ` [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise() Jan Kara
2019-07-12 17:50 ` Darrick J. Wong
2019-07-23 3:08 ` Boaz Harrosh [this message]
2019-07-11 14:00 ` [PATCH 2/3] fs: Export generic_fadvise() Jan Kara
2019-07-12 17:50 ` Darrick J. Wong
2019-07-11 14:00 ` [PATCH 3/3] xfs: Fix stale data exposure when readahead races with hole punch Jan Kara
2019-07-11 15:28 ` Amir Goldstein
2019-07-11 15:49 ` Darrick J. Wong
2019-07-12 12:00 ` Jan Kara
2019-07-12 17:56 ` Darrick J. Wong
2019-08-29 13:10 [PATCH 0/3 v2] xfs: Fix races between readahead and hole punching Jan Kara
2019-08-29 13:10 ` [PATCH 1/3] mm: Handle MADV_WILLNEED through vfs_fadvise() Jan Kara
2019-08-29 15:49 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9da4596e-7de2-9ba1-0fc0-62bf83c39488@plexistor.com \
--to=boaz@plexistor.com \
--cc=amir73il@gmail.com \
--cc=jack@suse.cz \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=linux-xfs@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).