From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: David Laight To: 'Arnd Bergmann' , "viro@zeniv.linux.org.uk" CC: "linux-fsdevel@vger.kernel.org" , "stable@vger.kernel.org" , "Yan, Zheng" , Sage Weil , Ilya Dryomov , Chengguang Xu , "ceph-devel@vger.kernel.org" , "linux-kernel@vger.kernel.org" Subject: RE: [PATCH v2 04/17] ceph: fix compat_ioctl for ceph_dir_operations Date: Wed, 12 Sep 2018 16:12:17 +0000 Message-ID: <9e5f6ad82a2344c095234b39224605d4@AcuMS.aculab.com> References: <20180912150142.157913-1-arnd@arndb.de> <20180912150142.157913-4-arnd@arndb.de> In-Reply-To: <20180912150142.157913-4-arnd@arndb.de> Content-Language: en-US MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: From: Arnd Bergmann > Sent: 12 September 2018 16:01 > > The ceph_ioctl function is used both for files and directories, but only > the files support doing that in 32-bit compat mode. > > For consistency, add the same compat handler to the dir operations > as well. Have you verified that all the relevant ioctl buffer structures are exactly the same for 32bit and 64bit applications? David - Registered Address Lakeside, Bramley Road, Mount Farm, Milton Keynes, MK1 1PT, UK Registration No: 1397386 (Wales)