From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.1 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2C9CAC43141 for ; Mon, 25 Nov 2019 09:27:51 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id E802F20823 for ; Mon, 25 Nov 2019 09:27:50 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=web.de header.i=@web.de header.b="lYxAgR/T" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727263AbfKYJ1t (ORCPT ); Mon, 25 Nov 2019 04:27:49 -0500 Received: from mout.web.de ([212.227.17.11]:54593 "EHLO mout.web.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727006AbfKYJ1s (ORCPT ); Mon, 25 Nov 2019 04:27:48 -0500 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=web.de; s=dbaedf251592; t=1574673967; bh=q1sAJv2V0p+xOdIEo8orruYj5GJ7Ns4QAVOLhuRMv7w=; h=X-UI-Sender-Class:Subject:To:Cc:References:From:Date:In-Reply-To; b=lYxAgR/TbHJqDDLeWAttAYhfSVHOmpIDe9LBe72JixA76eKfRpH5+2iuB3g0xH6FQ Fr4p0wUtQRYmzs+gHFr+z1NB0Z1A2/ALGgZWvg1oy9NR8JjorwtLYoKx78In4fWTBu j3/aHYwDBWGxMUKw3jJccr073eRMuRtGqL+96g6I= X-UI-Sender-Class: c548c8c5-30a9-4db5-a2e7-cb6cb037b8f9 Received: from [192.168.1.3] ([93.135.130.213]) by smtp.web.de (mrweb102 [213.165.67.124]) with ESMTPSA (Nemesis) id 0LwHkw-1hl3dw45Gg-01811S; Mon, 25 Nov 2019 10:26:07 +0100 Subject: Re: [PATCH v5 04/13] exfat: add directory operations To: Namjae Jeon , linux-fsdevel@vger.kernel.org Cc: linux-kernel@vger.kernel.org, Christoph Hellwig , Daniel Wagner , Greg Kroah-Hartman , Nikolay Borisov , Sungjong Seo , =?UTF-8?Q?Valdis_Kl=c4=93tnieks?= , linkinjeon@gmail.com References: <20191125000326.24561-1-namjae.jeon@samsung.com> <20191125000326.24561-5-namjae.jeon@samsung.com> From: Markus Elfring Autocrypt: addr=Markus.Elfring@web.de; prefer-encrypt=mutual; keydata= mQINBFg2+xABEADBJW2hoUoFXVFWTeKbqqif8VjszdMkriilx90WB5c0ddWQX14h6w5bT/A8 +v43YoGpDNyhgA0w9CEhuwfZrE91GocMtjLO67TAc2i2nxMc/FJRDI0OemO4VJ9RwID6ltwt mpVJgXGKkNJ1ey+QOXouzlErVvE2fRh+KXXN1Q7fSmTJlAW9XJYHS3BDHb0uRpymRSX3O+E2 lA87C7R8qAigPDZi6Z7UmwIA83ZMKXQ5stA0lhPyYgQcM7fh7V4ZYhnR0I5/qkUoxKpqaYLp YHBczVP+Zx/zHOM0KQphOMbU7X3c1pmMruoe6ti9uZzqZSLsF+NKXFEPBS665tQr66HJvZvY GMDlntZFAZ6xQvCC1r3MGoxEC1tuEa24vPCC9RZ9wk2sY5Csbva0WwYv3WKRZZBv8eIhGMxs rcpeGShRFyZ/0BYO53wZAPV1pEhGLLxd8eLN/nEWjJE0ejakPC1H/mt5F+yQBJAzz9JzbToU 5jKLu0SugNI18MspJut8AiA1M44CIWrNHXvWsQ+nnBKHDHHYZu7MoXlOmB32ndsfPthR3GSv jN7YD4Ad724H8fhRijmC1+RpuSce7w2JLj5cYj4MlccmNb8YUxsE8brY2WkXQYS8Ivse39MX BE66MQN0r5DQ6oqgoJ4gHIVBUv/ZwgcmUNS5gQkNCFA0dWXznQARAQABtCZNYXJrdXMgRWxm cmluZyA8TWFya3VzLkVsZnJpbmdAd2ViLmRlPokCVAQTAQgAPhYhBHDP0hzibeXjwQ/ITuU9 Figxg9azBQJYNvsQAhsjBQkJZgGABQsJCAcCBhUICQoLAgQWAgMBAh4BAheAAAoJEOU9Figx g9azcyMP/iVihZkZ4VyH3/wlV3nRiXvSreqg+pGPI3c8J6DjP9zvz7QHN35zWM++1yNek7Ar OVXwuKBo18ASlYzZPTFJZwQQdkZSV+atwIzG3US50ZZ4p7VyUuDuQQVVqFlaf6qZOkwHSnk+ CeGxlDz1POSHY17VbJG2CzPuqMfgBtqIU1dODFLpFq4oIAwEOG6fxRa59qbsTLXxyw+PzRaR LIjVOit28raM83Efk07JKow8URb4u1n7k9RGAcnsM5/WMLRbDYjWTx0lJ2WO9zYwPgRykhn2 sOyJVXk9xVESGTwEPbTtfHM+4x0n0gC6GzfTMvwvZ9G6xoM0S4/+lgbaaa9t5tT/PrsvJiob kfqDrPbmSwr2G5mHnSM9M7B+w8odjmQFOwAjfcxoVIHxC4Cl/GAAKsX3KNKTspCHR0Yag78w i8duH/eEd4tB8twcqCi3aCgWoIrhjNS0myusmuA89kAWFFW5z26qNCOefovCx8drdMXQfMYv g5lRk821ZCNBosfRUvcMXoY6lTwHLIDrEfkJQtjxfdTlWQdwr0mM5ye7vd83AManSQwutgpI q+wE8CNY2VN9xAlE7OhcmWXlnAw3MJLW863SXdGlnkA3N+U4BoKQSIToGuXARQ14IMNvfeKX NphLPpUUnUNdfxAHu/S3tPTc/E/oePbHo794dnEm57LuuQINBFg2+xABEADZg/T+4o5qj4cw nd0G5pFy7ACxk28mSrLuva9tyzqPgRZ2bdPiwNXJUvBg1es2u81urekeUvGvnERB/TKekp25 4wU3I2lEhIXj5NVdLc6eU5czZQs4YEZbu1U5iqhhZmKhlLrhLlZv2whLOXRlLwi4jAzXIZAu 76mT813jbczl2dwxFxcT8XRzk9+dwzNTdOg75683uinMgskiiul+dzd6sumdOhRZR7YBT+xC wzfykOgBKnzfFscMwKR0iuHNB+VdEnZw80XGZi4N1ku81DHxmo2HG3icg7CwO1ih2jx8ik0r riIyMhJrTXgR1hF6kQnX7p2mXe6K0s8tQFK0ZZmYpZuGYYsV05OvU8yqrRVL/GYvy4Xgplm3 DuMuC7/A9/BfmxZVEPAS1gW6QQ8vSO4zf60zREKoSNYeiv+tURM2KOEj8tCMZN3k3sNASfoG fMvTvOjT0yzMbJsI1jwLwy5uA2JVdSLoWzBD8awZ2X/eCU9YDZeGuWmxzIHvkuMj8FfX8cK/ 2m437UA877eqmcgiEy/3B7XeHUipOL83gjfq4ETzVmxVswkVvZvR6j2blQVr+MhCZPq83Ota xNB7QptPxJuNRZ49gtT6uQkyGI+2daXqkj/Mot5tKxNKtM1Vbr/3b+AEMA7qLz7QjhgGJcie qp4b0gELjY1Oe9dBAXMiDwARAQABiQI8BBgBCAAmFiEEcM/SHOJt5ePBD8hO5T0WKDGD1rMF Alg2+xACGwwFCQlmAYAACgkQ5T0WKDGD1rOYSw/+P6fYSZjTJDAl9XNfXRjRRyJSfaw6N1pA Ahuu0MIa3djFRuFCrAHUaaFZf5V2iW5xhGnrhDwE1Ksf7tlstSne/G0a+Ef7vhUyeTn6U/0m +/BrsCsBUXhqeNuraGUtaleatQijXfuemUwgB+mE3B0SobE601XLo6MYIhPh8MG32MKO5kOY hB5jzyor7WoN3ETVNQoGgMzPVWIRElwpcXr+yGoTLAOpG7nkAUBBj9n9TPpSdt/npfok9ZfL /Q+ranrxb2Cy4tvOPxeVfR58XveX85ICrW9VHPVq9sJf/a24bMm6+qEg1V/G7u/AM3fM8U2m tdrTqOrfxklZ7beppGKzC1/WLrcr072vrdiN0icyOHQlfWmaPv0pUnW3AwtiMYngT96BevfA qlwaymjPTvH+cTXScnbydfOQW8220JQwykUe+sHRZfAF5TS2YCkQvsyf7vIpSqo/ttDk4+xc Z/wsLiWTgKlih2QYULvW61XU+mWsK8+ZlYUrRMpkauN4CJ5yTpvp+Orcz5KixHQmc5tbkLWf x0n1QFc1xxJhbzN+r9djSGGN/5IBDfUqSANC8cWzHpWaHmSuU3JSAMB/N+yQjIad2ztTckZY pwT6oxng29LzZspTYUEzMz3wK2jQHw+U66qBFk8whA7B2uAU1QdGyPgahLYSOa4XAEGb6wbI FEE= Message-ID: <9fb7a74f-abf4-0842-5602-d8e5706fc75d@web.de> Date: Mon, 25 Nov 2019 10:26:03 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.2.2 MIME-Version: 1.0 In-Reply-To: <20191125000326.24561-5-namjae.jeon@samsung.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: quoted-printable X-Provags-ID: V03:K1:cn1TRwErewaa9WdsJCQypyG5yBNn3E/wJy8G/ALopUACgPpsv3U U9BJtniJVf+JyzX906GqLZwojv2t4TlraromiGh/cY1SW8+6lARggXb/qkigr8fBEbu4tVP gSkDR9uaSg2sblLBw/bF62kCDb8WX7VL5DWup7iQU+tCYnLbGIb6aLSanEN0SOS/y0dX9si 5DUH3RsgtdWRzFIgvzigg== X-UI-Out-Filterresults: notjunk:1;V03:K0:+cls4Fba/Rk=:jkK71OlUyUCaUMHPm6fXsj 85aAGKxdhRci09p8oHM3QeH3aRRGNCcZi+JU5F5F17TWDLnEZmaM4QqVjgRZbpuKeHbtTtTCZ zWWGyDq3drOySdgMG8TNwn8YwniMOvq9RUdQF9vPInhQOlNRN62l7wvjObs2v43GF5Xs/6KEf HZTyE8E3KL70zxaNEudQZI9befvjN2/uvTe2xKwJ6Daj4h47XOpX2EFfERQ94H2QRUrQJEEXK EQ2nWG4DyCbmBX7u7fHhb4tXGipFl/SvqfK550l74FTtI+Ct5wz+SykQAmzGgvyQ1qI4GmuPG bRE1RkD+GD5Li8FY3MctQKDSoHxeAEFgSxviQP+wlvPlFRX5qLe2hj2LEyp0Q0kwA/7zbaSXx FV7eLzJPMyOSBET7heLlgPm1kUkztz5SHZ1VzYkg32dPftaRxpnVrk2n/rUWeLsQpILUjw4Od tbxBy1Rs7xIj6MYzKY4Hy8oNYXXgGK5pWvmiDrHSco8IA3VwpawLUzDld3Vb3COyfwNtGdqex +GL0uV07Qdgy1GjRHbcDPZ4+0NDSUHhDmsGblUfKpJKrKKV8alUFSotlDdj24/JoYS2WvsRIX Q8zuVmIWmKP1AUyZOJ+cCv+CRSpkHAB78sdtgB6IJgewibcD6vewi62IEhP/T2pGNF83rEnyl 0WPrhv/uTz1f+MgP0m6odtQ2fMkyaGRQClDP5TpwKGs9Nad5k8xUO8jvinGlrp3xV5ZSVZi1D kZ/A6YqIhKP6bxo1MGo7Aw2qKkDMysDRQ8XbSQk/c8tykXRkJhg0acqHeWONBZasEdM/QHsKO FvHy+LwAqp/67CHTtUNlnykQPU7lVlVmXaFacG2NttZS2YdfmaQcmr75a0dVnlSOgX7nxqraq soEdUdMoai1n2DtnRAImR052hdpzNEb5TdmSAPgqqy+ojLWtB/etKndbnx3auw+bE7+fqmaTC TBLUGF1OoxYe9lLJZPBSsUXXtBFmAyjnw0n6jfpJLXy5QuE2sH8Vs0rZtMhOcmm+2SJSr5pZV Emapos01xWZ2g4DoekV4mz/MezMRKTrY//VfgYzv4OWa38i44q5ik+AucXzKRNML70MRDiMUy xW6aziqWFXd8/cuNc31UrP/ieAEzyzF+ZmWu+WmW437vu21TDMGl4cW4H892ojmMCMxhfghAR Pe7Llyjz4XWVU3UAjoDEnw6zylVqPSgqTz+xOEQhgCj3HLlLAZlEVu8D2/gDntSKqk8IMjL73 x90c+rCB2GRKx4STQTnd+xWa6X/sgR6V+noO2rkvsCyo84C+vPFWbuznHx/0= Sender: linux-fsdevel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-fsdevel@vger.kernel.org =E2=80=A6 > +int exfat_find_dir_entry(struct super_block *sb, struct exfat_inode_inf= o *ei, > + struct exfat_chain *p_dir, struct exfat_uni_name *p_uniname, > + int num_entries, unsigned int type) > +{ =E2=80=A6 > + unsigned short entry_uniname[16], *uniname =3D NULL, unichar; Would you like to reduce the scope for these variables according to an if = branch for the condition =E2=80=9Centry_type =3D=3D TYPE_EXTEND=E2=80=9D? =E2=80=A6 > + struct buffer_head *bh =3D NULL; * How do you think about to move the definition for this variable to the beginning of the for loop? * Can this pointer initialisation be omitted? Regards, Markus