From: "Besogonov, Aleksei" <cyberax@amazon.com>
To: "Darrick J. Wong" <darrick.wong@oracle.com>
Cc: "linux-xfs@vger.kernel.org" <linux-xfs@vger.kernel.org>,
"linux-fsdevel@vger.kernel.org" <linux-fsdevel@vger.kernel.org>
Subject: Re: [PATCH 0/2] RFC: iomap-based swap file activation
Date: Fri, 20 Apr 2018 22:38:49 +0000 [thread overview]
Message-ID: <ACC8E6C0-3FD7-4696-86E0-BD397E61176A@amazon.com> (raw)
In-Reply-To: <20180420222541.GC24738@magnolia>
Sorry for top-posting.
I'm sorry I missed your patch. It's definitely better than mine in the number
of validations it does.
My only comment is, shouldn't we allow blocks that are not page-aligned?
The current generic_swapfile_activate will simply discard the leading unaligned
sectors. Your patch will immediately error out in this case.
I tried to replicate the same behavior by doing ALIGN on the iomap addr.
On 4/20/18, 15:26, "Darrick J. Wong" <darrick.wong@oracle.com> wrote:
On Fri, Apr 20, 2018 at 10:08:13PM +0000, Aleksei Besogonov wrote:
> This patch set adds iomap-based swap file initialization, this allows
> it to use files with holes on XFS for swap.
Um... there's already a patch[1] implementing this out for review on the
mailing list. Could you please take a look at that instead?
--D
[1] https://marc.info/?l=linux-xfs&m=152401984810062&w=2
>
> Aleksei Besogonov (2):
> fs: Add iomap_swap_activate
> xfs: add support for iomap-based swapfile activation
>
> fs/iomap.c | 87 +++++++++++++++++++++++++++++++++++++++++++++++++++
> fs/xfs/xfs_aops.c | 7 +++++
> include/linux/iomap.h | 5 +++
> mm/swapfile.c | 1 +
> 4 files changed, 100 insertions(+)
>
> --
> 2.14.1
>
> --
> To unsubscribe from this list: send the line "unsubscribe linux-xfs" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
next prev parent reply other threads:[~2018-04-20 22:38 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 22:08 [PATCH 0/2] RFC: iomap-based swap file activation Aleksei Besogonov
2018-04-20 22:08 ` [PATCH 1/2] fs: Add iomap_swap_activate Aleksei Besogonov
2018-04-25 21:34 ` kbuild test robot
2018-04-25 21:38 ` kbuild test robot
2018-04-20 22:08 ` [PATCH 2/2] xfs: add support for iomap-based swapfile activation Aleksei Besogonov
2018-04-20 22:25 ` [PATCH 0/2] RFC: iomap-based swap file activation Darrick J. Wong
2018-04-20 22:38 ` Besogonov, Aleksei [this message]
2018-05-16 15:59 ` Darrick J. Wong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=ACC8E6C0-3FD7-4696-86E0-BD397E61176A@amazon.com \
--to=cyberax@amazon.com \
--cc=darrick.wong@oracle.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-xfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).