From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from g2t1383g.austin.hpe.com ([15.233.16.89]:22431 "EHLO g2t1383g.austin.hpe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727031AbeIJWxs (ORCPT ); Mon, 10 Sep 2018 18:53:48 -0400 Received: from g2t2352.austin.hpe.com (g2t2352.austin.hpe.com [15.233.44.25]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by g2t1383g.austin.hpe.com (Postfix) with ESMTPS id 8E06961F for ; Mon, 10 Sep 2018 17:58:32 +0000 (UTC) From: "Elliott, Robert (Persistent Memory)" To: "Kani, Toshi" , "jack@suse.cz" CC: "linux-fsdevel@vger.kernel.org" , "linux-nvdimm@lists.01.org" Subject: RE: open sets ext4_da_aops for DAX existing files Date: Mon, 10 Sep 2018 17:58:10 +0000 Message-ID: References: <76e07643e9c36e4273588bd3e7f29d1393de4c3d.camel@hpe.com> <20180910142902.GA30197@quack2.suse.cz> <0768c59f2d5391ff7678370fbc72cb664fca25fd.camel@hpe.com> In-Reply-To: <0768c59f2d5391ff7678370fbc72cb664fca25fd.camel@hpe.com> Content-Language: en-US Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT MIME-Version: 1.0 Sender: linux-fsdevel-owner@vger.kernel.org List-ID: > -----Original Message----- > From: Linux-nvdimm [mailto:linux-nvdimm-bounces@lists.01.org] On Behalf Of Kani, Toshi > Sent: Monday, September 10, 2018 9:52 AM > To: jack@suse.cz > Cc: linux-fsdevel@vger.kernel.org; linux-nvdimm@lists.01.org > Subject: Re: open sets ext4_da_aops for DAX existing files ... > > Good catch. Will you send a fix? I.e., call ext4_set_inode_flags() earlier > > in the ext4_iget()? Did this bug have any user visible manifestations? > > Yes, sync did not flush processor cache. > > > Please also add: > > > > Fixes: 5f0663bb4a64f588f0a2dd6d1be68d40f9af0086 > > > > so that stable automation picks this up. Thanks! > > > > Will do. > Also check if the same problem exists with ext2. --- Robert Elliott, HPE Persistent Memory